Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format numbers, amounts, totals and sums of tokens consistently #9

Open
ricburton opened this issue Feb 7, 2022 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@ricburton
Copy link
Member

IMG_8334
CleanShot 2022-02-06 at 23 02 24@2x

We should try to take into account assets’ prices and amounts when presenting the numbers that comprise balances.

$3k ETH needs more decimal places for the amounts of the token than $0.48 GRT.

This feels like a good framework for when to truncate and when to expand on numbers.

The quick fix is to apply this to the Balances section inside the wallet screen.

The longer fix is a consistent approach to number formatting, fiat currency values, and token prices.

I like to use SF Mono Light for prepended currency symbols and everything after the decimal place.

I use SF Mono Medium for the meat of a number.

@ricburton ricburton added the good first issue Good for newcomers label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant