Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate output_locking_bytecode_prefix_index to 35 bytes to cover entire locking bytecode for P2SH32 #60

Open
bitjson opened this issue Aug 8, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@bitjson
Copy link
Member

bitjson commented Aug 8, 2023

Currently, search_output() won't appear to work for P2SH32 because no exact match will be found in the 25-byte index for 35-byte P2SH32 queries, even if the index contains the first 25 bytes of the matching result. We just need the next DB migration to extend that index from 25 bytes to 35 bytes to cover the whole length of P2SH32.

Current workaround is to simply use search_output_prefix() rather than search_output() for P2SH32 queries, but in the long term, we should migrate the index to avoid new users having to understand what's happening here.

@bitjson bitjson added the good first issue Good for newcomers label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant