Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Expected Output Files #275

Open
d-sonuga opened this issue Aug 13, 2024 · 1 comment
Open

Missing Expected Output Files #275

d-sonuga opened this issue Aug 13, 2024 · 1 comment

Comments

@d-sonuga
Copy link

The benchmarks in benchmarks/libsodium are missing their expected stdout and stderr files.

@jlb6740
Copy link
Collaborator

jlb6740 commented Aug 15, 2024

I believe the checker here uses the basename of the wasmfile as the basis for the filename used for stderr. This probably should change to something more generic so that we don't have a bunch of redundant stderr.expected files. In this case all benchmarks are expected to return '0' to stdout. Will confirm and work on the patch to make a default.stderr.expected and default.stdout.expected when we don't care for the distinction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants