Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-deterministic output for html-in-md rendering #1101

Open
ricochet opened this issue Dec 5, 2024 · 1 comment
Open

Non-deterministic output for html-in-md rendering #1101

ricochet opened this issue Dec 5, 2024 · 1 comment

Comments

@ricochet
Copy link

ricochet commented Dec 5, 2024

The output order changes if --all-features is passed in versus --features= even in the case of the same feature set.

git clone https://github.com/WebAssembly/wasi-cli.git

wit-bindgen markdown wit --html-in-md --all-features
git add

wit-bindgen markdown wit --html-in-md --features=cli-exit-with-code
# note diff
# there's only one feature in this package so the output should be the same
@sunfishcode
Copy link
Member

sunfishcode commented Dec 6, 2024

It is deterministic; in the cli worlds, the full equivalent of --all-features is --features=clocks-timezone,cli-exit-with-code,network-error-code.

This is because wasi-cli's worlds import from their dependencies' worlds, such as:

@since(version = 0.2.0)
world imports {
  @since(version = 0.2.0)
  include wasi:clocks/[email protected];

so features in their dependencies such as wasi-clocks' clocks-timezone influence the contents of the cli worlds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants