Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DebugKit.safeTld complaining about full domains #1007

Open
boindil opened this issue Jun 15, 2024 · 3 comments
Open

DebugKit.safeTld complaining about full domains #1007

boindil opened this issue Jun 15, 2024 · 3 comments

Comments

@boindil
Copy link

boindil commented Jun 15, 2024

Hi,

I've just installed cakephp in version 5.0 fresh - however I've notices, that the setting DebugKit.safeTld doesnt seem to accept full domains. For us this doesnt make any sense since we dont have a local dev environment with such a domain.

Why not just accept a simple domain (e.g. testenv.cakephp.com)? I guess it would be pretty easy to implement and I dont see why only the actual last portion should be matched against ...

@dereuromark
Copy link
Member

Feel free to make a PR with suggested changes

@ADmad
Copy link
Member

ADmad commented Aug 9, 2024

forEnable accepts a callable, so you can use 'forceEnable' => fn () => env('HTTP_HOST') === 'mydomain.com' to match a specific domain.

Copy link

github-actions bot commented Dec 8, 2024

This issue is stale because it has been open for 120 days with no activity. Remove the stale label or comment or this will be closed in 15 days

@github-actions github-actions bot added stale and removed stale labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@dereuromark @ADmad @boindil and others