-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for propshaft #257
Comments
@jcoyne can you help me understand what supporting propshaft would entail? Is this a matter of updating the capistrano-rails REAMDE with some guidance on what value propshaft users should use for |
@mattbrictson I imaging it would just add a new pattern in here: rails/lib/capistrano/tasks/assets.rake Line 139 in 082255a
https://github.com/rails/propshaft/blob/793a20e74201cd6c97f22fb8df75f353e7aebe5b/lib/propshaft/processor.rb#L4 |
I've done this and it works as a workaround: set :assets_manifests, -> {
[release_path.join("public", fetch(:assets_prefix), '.manifest.json')]
} But now that propshaft is included by Rails, it makes sense to make this a default part of capistrano-rails. |
I have set in
as advised. And this works well with |
I created PR (#265), which adds the Propshaft manifest file ( |
Similar to #235, when using propshaft rather than sprockets
the
deploy:assets:backup_manifest
task fails because propshaft makes a manifest named:public/assets/.manifest.json
which does not match the existing patterns in:assets_manifests
The text was updated successfully, but these errors were encountered: