-
Notifications
You must be signed in to change notification settings - Fork 5
/
prefer-shorthand-properties.ts
127 lines (109 loc) · 3.91 KB
/
prefer-shorthand-properties.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
import { isPandaAttribute, isPandaProp, isRecipeVariant, resolveLonghand, resolveShorthands } from '../utils/helpers'
import { type Rule, createRule } from '../utils'
import { isIdentifier, isJSXIdentifier } from '../utils/nodes'
import type { TSESTree } from '@typescript-eslint/utils'
export const RULE_NAME = 'prefer-shorthand-properties'
const rule: Rule = createRule({
name: RULE_NAME,
meta: {
docs: {
description:
'Discourage the use of longhand properties and promote the preference for shorthand properties in the codebase.',
},
messages: {
shorthand: 'Use shorthand property instead of `{{longhand}}`. Prefer `{{shorthand}}`.',
replace: 'Replace `{{longhand}}` with `{{shorthand}}`.',
},
type: 'suggestion',
hasSuggestions: true,
schema: [],
},
defaultOptions: [],
create(context) {
// Cache for resolved longhand properties
const longhandCache = new Map<string, string | undefined>()
const getLonghand = (name: string): string | undefined => {
if (longhandCache.has(name)) {
return longhandCache.get(name)!
}
const longhand = resolveLonghand(name, context)
longhandCache.set(name, longhand)
return longhand
}
// Cache for resolved shorthands
const shorthandsCache = new Map<string, string[] | undefined>()
const getShorthands = (name: string): string[] | undefined => {
if (shorthandsCache.has(name)) {
return shorthandsCache.get(name)!
}
const shorthands = resolveShorthands(name, context)
shorthandsCache.set(name, shorthands)
return shorthands
}
// Caches for helper functions
const pandaPropCache = new WeakMap<TSESTree.JSXAttribute, boolean | undefined>()
const isCachedPandaProp = (node: TSESTree.JSXAttribute): boolean => {
if (pandaPropCache.has(node)) {
return pandaPropCache.get(node)!
}
const result = isPandaProp(node, context)
pandaPropCache.set(node, result)
return !!result
}
const pandaAttributeCache = new WeakMap<TSESTree.Property, boolean | undefined>()
const isCachedPandaAttribute = (node: TSESTree.Property): boolean => {
if (pandaAttributeCache.has(node)) {
return pandaAttributeCache.get(node)!
}
const result = isPandaAttribute(node, context)
pandaAttributeCache.set(node, result)
return !!result
}
const recipeVariantCache = new WeakMap<TSESTree.Property, boolean | undefined>()
const isCachedRecipeVariant = (node: TSESTree.Property): boolean => {
if (recipeVariantCache.has(node)) {
return recipeVariantCache.get(node)!
}
const result = isRecipeVariant(node, context)
recipeVariantCache.set(node, result)
return !!result
}
const sendReport = (node: TSESTree.Identifier | TSESTree.JSXIdentifier) => {
const longhand = getLonghand(node.name)
if (longhand) return // If it's already shorthand, no need to report
const shorthands = getShorthands(node.name)
if (!shorthands || shorthands.length === 0) return
const shorthandList = shorthands.map((s) => `\`${s}\``).join(', ')
const data = {
longhand: node.name,
shorthand: shorthandList,
}
context.report({
node,
messageId: 'shorthand',
data,
suggest: [
{
messageId: 'replace',
data,
fix: (fixer) => fixer.replaceText(node, shorthands[0]),
},
],
})
}
return {
JSXAttribute(node: TSESTree.JSXAttribute) {
if (!isJSXIdentifier(node.name)) return
if (!isCachedPandaProp(node)) return
sendReport(node.name)
},
Property(node: TSESTree.Property) {
if (!isIdentifier(node.key)) return
if (!isCachedPandaAttribute(node)) return
if (isCachedRecipeVariant(node)) return
sendReport(node.key)
},
}
},
})
export default rule