Error when enable -Wthread-safety-analysis

[sayboras]

When -Wthread-safety-analysis flag is enabled, the below error occurs.

Thanks to @tcnghia for reporting the issue.

Patch

diff --git a/bazel/toolchains/BUILD b/bazel/toolchains/BUILD
index a7bc5ac7..e371b51f 100644
--- a/bazel/toolchains/BUILD
+++ b/bazel/toolchains/BUILD
@@ -39,6 +39,7 @@ cc_toolchain_config(
         "-Wunused-but-set-parameter",
         "-Wno-free-nonheap-object",
         "-fno-omit-frame-pointer",
+        "-Wthread-safety-analysis",
         # Needed by Envoy dependencies to build:
         "-Wno-unused-command-line-argument",  # tcmalloc needs this since -fuse-ld was added above
         "-Wno-deprecated-builtins",
@@ -137,6 +138,7 @@ cc_toolchain_config(
         "-Wunused-but-set-parameter",
         "-Wno-free-nonheap-object",
         "-fno-omit-frame-pointer",
+        "-Wthread-safety-analysis",
         # Needed by Envoy dependencies to build:
         "-Wno-unused-command-line-argument",  # tcmalloc needs this since -fuse-ld was added above
         "-Wno-deprecated-builtins",

Error

...
ERROR: /home/tammach/go/src/github.com/cilium/proxy/cilium/BUILD:172:17: Compiling cilium/uds_client.cc failed: (Exit 1): clang-17 failed: error executing command (from target //cilium:uds_client_lib) /usr/bin/clang-17 '--target=x86_64-unknown-linux-gnu' '-fuse-ld=lld' -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer ... (remaining 196 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
cilium/uds_client.cc:62:7: error: reading variable 'logging_limiter_' requires holding mutex 'fd_mutex_' [-Werror,-Wthread-safety-analysis]
   62 |   if (logging_limiter_->consume(1, false)) {
      |       ^
cilium/uds_client.cc:63:85: error: reading variable 'errno_' requires holding mutex 'fd_mutex_' [-Werror,-Wthread-safety-analysis]
   63 |     ENVOY_LOG(warn, "Logging to {} failed: {}", asStringView(), Envoy::errorDetails(errno_));
      |                                                                                     ^
cilium/uds_client.cc:63:85: error: reading variable 'errno_' requires holding mutex 'fd_mutex_' [-Werror,-Wthread-safety-analysis]
3 errors generated.
Target //:cilium-envoy failed to build