Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance bugs #276

Open
armanogan opened this issue May 28, 2019 · 3 comments
Open

Performance bugs #276

armanogan opened this issue May 28, 2019 · 3 comments

Comments

@armanogan
Copy link

Hey guys,

I wondered,why you are attaching a lot of events mousedown,when you can use only 1and your mousemove and mouseup events are working always even if there is no element attached. You need to attache mousemove and mouse ONLY after mousedown event and remove the events on mouse up.The plugin works good but the code dirty is dirty.

@claviska
Copy link
Owner

You're right about the mousemove handler firing too frequently — it should only fire when the color picker is open. However, your observation isn't presented very tactfully.

Since you obviously took more than a passing glance at the code, why didn't you bother to submit a PR?

@armanogan
Copy link
Author

I have already re-coded as it should be, if you want you can take a look.

jquery.minicolors.zip

@kolosovsky
Copy link

I have the same issue. Mousemove event triggers angular change detection and therefore causes performance issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants