You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wondered,why you are attaching a lot of events mousedown,when you can use only 1and your mousemove and mouseup events are working always even if there is no element attached. You need to attache mousemove and mouse ONLY after mousedown event and remove the events on mouse up.The plugin works good but the code dirty is dirty.
The text was updated successfully, but these errors were encountered:
You're right about the mousemove handler firing too frequently — it should only fire when the color picker is open. However, your observation isn't presented very tactfully.
Since you obviously took more than a passing glance at the code, why didn't you bother to submit a PR?
Hey guys,
I wondered,why you are attaching a lot of events mousedown,when you can use only 1and your mousemove and mouseup events are working always even if there is no element attached. You need to attache mousemove and mouse ONLY after mousedown event and remove the events on mouse up.The plugin works good but the code dirty is dirty.
The text was updated successfully, but these errors were encountered: