Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return &str from get_attribute #74

Open
jyn514 opened this issue Oct 30, 2020 · 0 comments
Open

Return &str from get_attribute #74

jyn514 opened this issue Oct 30, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jyn514
Copy link
Contributor

jyn514 commented Oct 30, 2020

Most of the time I'm looking at an attribute, I don't actually need to copy it. But get_attribute() makes a copy anyway. It would be nice to return a borrow instead.

This would also require changing Bytes::as_string() to return a borrow.
@kornelski kornelski added the enhancement New feature or request label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kornelski @jyn514