Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SetConfig return an error #147

Open
astrieanna opened this issue Oct 17, 2019 · 2 comments
Open

Make SetConfig return an error #147

astrieanna opened this issue Oct 17, 2019 · 2 comments

Comments

@astrieanna
Copy link
Contributor

When Duffle calls SetConfig, it gets no feedback to relay to the user as to whether the settings were successfully applied. Duffle should be able to fail if the settings were not valid.

This is the relevant line to change the Configurable interface, but it would also need to change in each of the drivers.

@radu-matei
Copy link
Member

radu-matei commented Oct 17, 2019

@carolynvs
Copy link
Contributor

We'd be fine with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants