Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tutorial : Build a NoSQL Database using Go #1285

Closed
wants to merge 1 commit into from
Closed

New tutorial : Build a NoSQL Database using Go #1285

wants to merge 1 commit into from

Conversation

noam-no
Copy link

@noam-no noam-no commented Nov 28, 2024 •
edited
Loading

Added Build a NoSQL Database using Go, this fix #1271, and it prevents the stalling of #1270

@noam-no
New tutorial fixing codecrafters-io#1271
534b41f 
added Build a NoSQL Database using Go
@noam-no noam-no changed the title New tutorial fixing #1271 New tutorial : Build a NoSQL Database using Go Nov 28, 2024
@FabriLluvia
Copy link

Hello. What do you mean with stalling? Thank you!

@FabriLluvia
Copy link

By the way also add it to my PR, #1270

@FabriLluvia FabriLluvia mentioned this pull request Nov 30, 2024
Open
@DylanSherwoodCode
Copy link

DylanSherwoodCode commented Nov 30, 2024 via email

@FabriLluvia
Copy link

I have unsubscribed from this thread, the emails, notifications on GitHub, your personal account, and you are still sending an email with every question, please make it stop somehow.
…
On Fri, Nov 29, 2024 at 19:39 FabriLluvia @.> wrote: By the way also add it to my PR, #1270 <#1270> — Reply to this email directly, view it on GitHub <#1285 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATU33LDXSIJHIZSRGQPQ7532DECLXAVCNFSM6AAAAABSVBZBSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYG42TKNBYGA . You are receiving this because you are subscribed to this thread.Message ID: @.>

What do you mean? Thanks

@noam-no
Copy link
Author

noam-no commented Dec 5, 2024

Hello. What do you mean with stalling? Thank you!

I just thought that maybe they were waiting for the fix before merging, but now everything seems to be good. I'll close this since you fixed it already.

@noam-no noam-no closed this Dec 5, 2024
@noam-no noam-no deleted the patch-1 branch December 5, 2024 15:12
@noam-no noam-no restored the patch-1 branch December 5, 2024 15:12
@noam-no noam-no deleted the patch-1 branch December 5, 2024 15:12
@FabriLluvia
Copy link

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build a NoSQL Database using Go
3 participants
@noam-no @FabriLluvia @DylanSherwoodCode