Update cucumber.rb #105
Open
Update cucumber.rb #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I'm requesting this extra regex option get added to cucumber.rb to fix an issue I'm having with Scenario Outlines.
Here is an example:
```
Scenario Outline: Example of scenario outline issue
Given User makes GET request to "www.give-me-a-json.com/api/json"
And User receives 200 response code
Then the JSON response at "data/someInteger" should be <integer>
Examples:
| integer |
| 5 |
```
^^^ The above will give me an undefined step reference error while conversely....
```
Scenario: Example of scenario outline issue
Given User makes GET request to "www.give-me-a-json.com/api/json"
And User receives 200 response code
Then the JSON response at "data/someInteger" should be 5
```
This will work fine. Adding <.*> will allow for examples table entries to be read, regardless of quotations. There may have to be an extra check within the method to account for someone trying to pass in a string without quotations using the examples table, which I'd be happy to provide if requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm requesting this extra regex option get added to cucumber.rb to fix an issue I'm having with Scenario Outlines.
Here is an example:
^^^ The above will give me an undefined step reference error while conversely....
This will work fine. Adding <.*> will allow for examples table entries to be read, regardless of quotations. It's also an improvement because if the value passed in by the examples table doesn't follow the regex, then it will throw a runtime error.