Stablize Ignition spec 3.5 #1922

madhu-pillai · 2024-08-14T07:48:01Z

https://issues.redhat.com/browse/COS-2870

I've completed the changes in ignition to stablize 3.5.0 from the issue template till Update Docs https://github.com/coreos/ignition/blob/main/.github/ISSUE_TEMPLATE/stabilize-checklist.md .
Kindly review and suggest for any further changes.

Fixes: #1925

prestist · 2024-08-19T14:39:31Z

@madhu-pillai Thank you for doing this;

Would you mind updating this checklist #1925 with the steps completed?

I dont think I could do a stablization without having a checkbox lol too many steps.

madhu-pillai · 2024-08-26T15:22:05Z

HI @prestist ,
I've updated the checklist that i finished in the issues.

prestist · 2024-08-27T13:21:23Z

@madhu-pillai awesome, so note; there are external packages that need to be updated after this lands and then additionally we need to stabilize ignition in butane | ignition-config-rs | ign-converter |. see #1553 (comment)

prestist · 2024-08-28T19:10:53Z

Ok @madhu-pillai I have reviewed your changes, it's a bit intense in one commit. Is there any way I could ask you to follow a similar structure to this

https://github.com/coreos/ignition/pull/1558/commits

To my eye; I dont see anything wrong with your PR however due to the sensitive nature I want to make sure before approving. Sorry for the difficult ask but its not very consumable atm.

madhu-pillai · 2024-08-29T06:24:53Z

Will do that...

prestist

Gennerally lgtm, small changes and a question;
Are we wanting CEX to be considered stable? @travier

config/v3_6_experimental/config.go

config/v3_5/config.go

prestist · 2024-09-16T15:49:06Z

config/doc/ignition.yaml

@@ -384,7 +384,7 @@ root:
              desc: describes the IBM Crypto Express (CEX) card configuration for the luks device.
              children:
                - name: enabled 
-                  desc: whether or not to use a CEX secure key to encrypt the luks device.


We should not make this change as a part of the pr, it makes it confusing. this can be fixed by the already opened external pr.

madhu-pillai · 2024-09-18T07:52:46Z

Hi, The moment before the push, the test was success. not sure why it failed on the go part.

prestist · 2024-09-18T13:07:54Z

You might need to rebase- golang 1.23 is having issues with the ./build script and there was a changed committed to main to fix it.

madhu-pillai · 2024-09-18T15:18:13Z

Hi, I did rebase before the push and it is upto date.

[root@a3elp53 ignition]# git remote -v
origin	[email protected]:madhu-pillai/ignition.git (fetch)
origin	[email protected]:madhu-pillai/ignition.git (push)
upstream	https://github.com/coreos/ignition.git (fetch)
upstream	https://github.com/coreos/ignition.git (push)
[root@a3elp53 ignition]# git push origin bump_ignition_3.5 -f
Everything up-to-date

a2079161 (HEAD -> bump_ignition_3.5, origin/bump_ignition_3.5) config: moved v3_5_experimental
b5d591ae docs: update for spec stablization
5cba417c docs: shuffle for spec stablization
e76023a8 tests: update for new experimental spec
846d3f7f *: update to v3_6_experimental spec
624e6cc4 config: copy v3_5 to v3_6_experimental and adapt for new experimental spec
6a978528 config: rename v3_5_experimental to v3_5 and stablize
39aca3c5 (upstream/main) Merge pull request #1942 from k0tran/patch-1
54afa542 docs: add bug fix entry for PR #1942
cd1c2cce Merge pull request #1940 from tormath1/tormath1/ignition
6eb35ed4 dracut: add dependency network to ignition-mount.service

prestist · 2024-09-18T17:18:39Z

@madhu-pillai it looks like unit-tests are failing; are you saying they are passing locally for you?

madhu-pillai · 2024-09-19T03:09:14Z

Hi @prestist , Yes, the test pass locally.

[root@a3elp53 ignition]# git status
On branch bump_ignition_3.5
Your branch is up to date with 'origin/bump_ignition_3.5'.

nothing to commit, working tree clean
[root@a3elp53 ignition]# ./test
Checking for license headers...
Using version from git: v2.19.0-82-g045b6800
Building ignition...
Building ignition-validate...
Checking gofix...
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
go fix: warning: no cgo types: exit status 1
Checking gofmt...

Checking govet...
Running tests...
?   	github.com/coreos/ignition/v2/config/doc	[no test files]
ok  	github.com/coreos/ignition/v2/config	(cached)	coverage: 0.0% of statements
ok  	github.com/coreos/ignition/v2/config/merge	(cached)	coverage: 93.6% of statements
?   	github.com/coreos/ignition/v2/config/shared/errors	[no test files]
?   	github.com/coreos/ignition/v2/config/shared/parse	[no test files]
?   	github.com/coreos/ignition/v2/config/shared/validations	[no test files]
?   	github.com/coreos/ignition/v2/config/shared	[no test files]
ok  	github.com/coreos/ignition/v2/config/translate	(cached)	coverage: 75.0% of statements
?   	github.com/coreos/ignition/v2/config/util	[no test files]
ok  	github.com/coreos/ignition/v2/config/v3_0	(cached)	coverage: 90.0% of statements
ok  	github.com/coreos/ignition/v2/config/v3_0/types	(cached)	coverage: 59.8% of statements
ok  	github.com/coreos/ignition/v2/config/v3_1	(cached)	coverage: 91.3% of statements
ok  	github.com/coreos/ignition/v2/config/v3_1/translate	(cached)	coverage: 100.0% of statements
ok  	github.com/coreos/ignition/v2/config/v3_1/types	(cached)	coverage: 61.9% of statements
ok  	github.com/coreos/ignition/v2/config/v3_2	(cached)	coverage: 91.3% of statements
ok  	github.com/coreos/ignition/v2/config/v3_2/translate	(cached)	coverage: 100.0% of statements
ok  	github.com/coreos/ignition/v2/config/v3_2/types	(cached)	coverage: 56.5% of statements
ok  	github.com/coreos/ignition/v2/config/v3_3	(cached)	coverage: 91.3% of statements
ok  	github.com/coreos/ignition/v2/config/v3_3/translate	(cached)	coverage: 100.0% of statements
ok  	github.com/coreos/ignition/v2/config/v3_3/types	(cached)	coverage: 58.9% of statements
ok  	github.com/coreos/ignition/v2/config/v3_4	(cached)	coverage: 91.3% of statements
ok  	github.com/coreos/ignition/v2/config/v3_4/translate	(cached)	coverage: 100.0% of statements
ok  	github.com/coreos/ignition/v2/config/v3_4/types	(cached)	coverage: 62.5% of statements
ok  	github.com/coreos/ignition/v2/config/v3_5	(cached)	coverage: 91.3% of statements
ok  	github.com/coreos/ignition/v2/config/v3_5/translate	(cached)	coverage: 100.0% of statements
ok  	github.com/coreos/ignition/v2/config/v3_5/types	(cached)	coverage: 62.1% of statements
ok  	github.com/coreos/ignition/v2/config/v3_6_experimental	(cached)	coverage: 91.3% of statements
ok  	github.com/coreos/ignition/v2/config/v3_6_experimental/translate	(cached)	coverage: 100.0% of statements
ok  	github.com/coreos/ignition/v2/config/v3_6_experimental/types	(cached)	coverage: 62.1% of statements
ok  	github.com/coreos/ignition/v2/config/validate	(cached)	coverage: 90.9% of statements
?   	github.com/coreos/ignition/v2/internal	[no test files]
?   	github.com/coreos/ignition/v2/internal/apply	[no test files]
?   	github.com/coreos/ignition/v2/internal/as_user	[no test files]
?   	github.com/coreos/ignition/v2/internal/distro	[no test files]
?   	github.com/coreos/ignition/v2/internal/doc	[no test files]
?   	github.com/coreos/ignition/v2/internal/earlyrand	[no test files]
?   	github.com/coreos/ignition/v2/internal/exec	[no test files]
?   	github.com/coreos/ignition/v2/internal/exec/stages	[no test files]
?   	github.com/coreos/ignition/v2/internal/exec/stages/disks	[no test files]
?   	github.com/coreos/ignition/v2/internal/exec/stages/fetch	[no test files]
ok  	github.com/coreos/ignition/v2/internal/exec/stages/fetch_offline	(cached)	coverage: 72.1% of statements
ok  	github.com/coreos/ignition/v2/internal/exec/stages/files	(cached)	coverage: 2.6% of statements
?   	github.com/coreos/ignition/v2/internal/exec/stages/kargs	[no test files]
?   	github.com/coreos/ignition/v2/internal/exec/stages/mount	[no test files]
?   	github.com/coreos/ignition/v2/internal/exec/stages/umount	[no test files]
ok  	github.com/coreos/ignition/v2/internal/exec/util	(cached)	coverage: 2.0% of statements
?   	github.com/coreos/ignition/v2/internal/log	[no test files]
?   	github.com/coreos/ignition/v2/internal/platform	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/akamai	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/aliyun	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/applehv	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/aws	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/azure	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/azurestack	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/cloudstack	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/cmdline	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/digitalocean	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/exoscale	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/file	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/gcp	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/hetzner	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/hyperv	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/ibmcloud	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/metal	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/nutanix	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/openstack	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/packet	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/powervs	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/proxmoxve	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/qemu	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/scaleway	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/system	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/util	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/virtualbox	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/kubevirt	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/vultr	[no test files]
?   	github.com/coreos/ignition/v2/internal/providers/zvm	[no test files]
ok  	github.com/coreos/ignition/v2/internal/providers/vmware	(cached)	coverage: 58.9% of statements
?   	github.com/coreos/ignition/v2/internal/register	[no test files]
ok  	github.com/coreos/ignition/v2/internal/registry	(cached)	coverage: 90.0% of statements
?   	github.com/coreos/ignition/v2/internal/sgdisk	[no test files]
ok  	github.com/coreos/ignition/v2/internal/resource	(cached)	coverage: 12.7% of statements
?   	github.com/coreos/ignition/v2/internal/state	[no test files]
?   	github.com/coreos/ignition/v2/internal/systemd	[no test files]
?   	github.com/coreos/ignition/v2/internal/util/tools/docs	[no test files]
?   	github.com/coreos/ignition/v2/internal/version	[no test files]
?   	github.com/coreos/ignition/v2/validate	[no test files]
ok  	github.com/coreos/ignition/v2/internal/util	(cached)	coverage: 33.9% of statements
Checking docs...
Found 10 sections in: docs/examples.md
Found 19 sections in: docs/migrating-configs.md
Success

travier · 2024-09-20T08:03:30Z

Gennerally lgtm, small changes and a question; Are we wanting CEX to be considered stable? @travier

Yes, this is why we need this spec stabilization.

travier · 2024-09-20T08:15:47Z

It's hard to review this as is as you need to strictly follow the steps and create intermediary commits to make the changes visible.

I'm re-splitting the changes.

See: #1558

We might also have to look at if we need to re-add: 7cff68f (#1558)

travier · 2024-09-20T08:32:50Z

Let's see if this passes tests. I'll have to review it again.

madhu-pillai · 2024-09-20T09:59:14Z

The test got passed when i push the PR as single commit as well as later i split the PR. Then i push the PR after the correction in config/doc/ignition.yaml and it keep fails in unit test. But the test runs fine at locally.

prestist · 2024-10-14T12:59:31Z

@travier the jenkins ci issue this was running into has been resolved. If you rebase, that failure should be no more.

travier · 2024-10-14T13:35:44Z

Thanks for fixing the CI! Rebased

prestist

LGTM! 🚀

Wow thank you both very much, this looks good to my eyes, the commit structure gives me much more confidence to verify this is correct, I am sure it was painful but thank you for making it happen.

madhu-pillai · 2024-10-21T05:12:32Z

Hi, Is there anything pending from my side to progress on the new feature?

prestist · 2024-10-21T19:11:22Z

@madhu-pillai

If you look at issue here => #1925

We will have to make the changes to some other packages once this is released.
It might be good to do another release so that we can not forget anything.
This part of stabilization is done though and can be merged.

Yikes wrong button sorry.

madhu-pillai force-pushed the bump_ignition_3.5 branch 2 times, most recently from c9ce1c5 to bed9df1 Compare August 30, 2024 18:28

prestist reviewed Sep 16, 2024

View reviewed changes

madhu-pillai force-pushed the bump_ignition_3.5 branch from bed9df1 to 045b680 Compare September 17, 2024 12:37

madhu-pillai force-pushed the bump_ignition_3.5 branch from 045b680 to a207916 Compare September 18, 2024 15:00

travier force-pushed the bump_ignition_3.5 branch from a207916 to fe10ff7 Compare September 20, 2024 08:32

travier force-pushed the bump_ignition_3.5 branch 2 times, most recently from c2758dc to 9721e97 Compare September 30, 2024 13:48

travier and others added 7 commits October 14, 2024 15:33

config: rename v3_5_experimental to v3_5

e98dd18

config/v3_5: stabilize

3b0b89b

config: copy v3_5 to v3_6_experimental

68efbc1

config/v3_6_experimental: adapt for new experimental spec

87e2d0c

*: update to v3_6_experimental spec

c6c5292

tests: update for new experimental spec

1f51620

docs: shuffle for spec stablization

4867377

docs: update for spec stablization

df18924

travier force-pushed the bump_ignition_3.5 branch from 9721e97 to df18924 Compare October 14, 2024 13:35

prestist approved these changes Oct 15, 2024

View reviewed changes

tormath1 mentioned this pull request Oct 21, 2024

OEM: Provide Proxmox images flatcar/scripts#1783

Merged

2 tasks

prestist closed this Oct 21, 2024

prestist reopened this Oct 21, 2024

prestist enabled auto-merge October 21, 2024 19:13

prestist mentioned this pull request Oct 21, 2024

Release v2.20.0 #1960

Closed

38 tasks

prestist merged commit 3ab7fc7 into coreos:main Oct 21, 2024
17 checks passed

tormath1 mentioned this pull request Oct 22, 2024

Add support for IONOS Cloud #1957

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stablize Ignition spec 3.5 #1922

Stablize Ignition spec 3.5 #1922

madhu-pillai commented Aug 14, 2024 •

edited by travier

Loading

prestist commented Aug 19, 2024 •

edited

Loading

madhu-pillai commented Aug 26, 2024

prestist commented Aug 27, 2024 •

edited

Loading

prestist commented Aug 28, 2024

madhu-pillai commented Aug 29, 2024

prestist left a comment

prestist Sep 16, 2024

madhu-pillai Sep 17, 2024

madhu-pillai commented Sep 18, 2024

prestist commented Sep 18, 2024

madhu-pillai commented Sep 18, 2024

prestist commented Sep 18, 2024

madhu-pillai commented Sep 19, 2024

travier commented Sep 20, 2024

travier commented Sep 20, 2024 •

edited

Loading

travier commented Sep 20, 2024

madhu-pillai commented Sep 20, 2024

prestist commented Oct 14, 2024

travier commented Oct 14, 2024 •

edited

Loading

prestist left a comment

madhu-pillai commented Oct 21, 2024

prestist commented Oct 21, 2024 •

edited

Loading

Stablize Ignition spec 3.5 #1922

Stablize Ignition spec 3.5 #1922

Conversation

madhu-pillai commented Aug 14, 2024 • edited by travier Loading

prestist commented Aug 19, 2024 • edited Loading

madhu-pillai commented Aug 26, 2024

prestist commented Aug 27, 2024 • edited Loading

prestist commented Aug 28, 2024

madhu-pillai commented Aug 29, 2024

prestist left a comment

Choose a reason for hiding this comment

prestist Sep 16, 2024

Choose a reason for hiding this comment

madhu-pillai Sep 17, 2024

Choose a reason for hiding this comment

madhu-pillai commented Sep 18, 2024

prestist commented Sep 18, 2024

madhu-pillai commented Sep 18, 2024

prestist commented Sep 18, 2024

madhu-pillai commented Sep 19, 2024

travier commented Sep 20, 2024

travier commented Sep 20, 2024 • edited Loading

travier commented Sep 20, 2024

madhu-pillai commented Sep 20, 2024

prestist commented Oct 14, 2024

travier commented Oct 14, 2024 • edited Loading

prestist left a comment

Choose a reason for hiding this comment

madhu-pillai commented Oct 21, 2024

prestist commented Oct 21, 2024 • edited Loading

madhu-pillai commented Aug 14, 2024 •

edited by travier

Loading

prestist commented Aug 19, 2024 •

edited

Loading

prestist commented Aug 27, 2024 •

edited

Loading

travier commented Sep 20, 2024 •

edited

Loading

travier commented Oct 14, 2024 •

edited

Loading

prestist commented Oct 21, 2024 •

edited

Loading