Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner-axe not provide all the axe core results #168

Open
foxpcteam opened this issue Apr 26, 2017 · 5 comments
Open

runner-axe not provide all the axe core results #168

foxpcteam opened this issue Apr 26, 2017 · 5 comments

Comments

@foxpcteam
Copy link

Hi,
after i have installed the runner-axe and run some tests i have noticed that i get not all the results that axe core provide.

for example, i have installed firefox axe add-on and i have test the same page. in the firefox add-on i get many issues. but when i run runner-axe i get only related to "contrast". am i missing something?

this is my code:

		const CrawlKit = require('crawlkit');
		const AxeRunner = require('crawlkit-runner-axe');	
		const crawler = new CrawlKit(website);
		// You could add a finder here in order to audit a whole network of pages 
		//crawler.addRunner('aXe', new AxeRunner());
		crawler.addRunner('aXe', new AxeRunner(), {
		  runOnly: {
			  type: 'tag',
			  values: ['wcag2aa']
			}
		});	 
		crawler.crawl()
			.then((data) => {
				res.send(JSON.stringify(data.results, true, 2));
			}, (err) => console.error(err));	
@joscha
Copy link
Member

joscha commented Apr 26, 2017

can you paste the firefox output here? I think it might be a case of configuring the runOnly parameter properly. Have you tried omitting that setting completely?

@foxpcteam
Copy link
Author

foxpcteam commented Apr 26, 2017

yes i have tried with:
crawler.addRunner('aXe', new AxeRunner());

here is an example:
you can test https://www.elegantthemes.com/
if firefox add-on you get:
37 violations found:
Results:
Buttons must have discernible text - 2 violations
Elements must have sufficient color contrast - 25 violations
Frames must have title attribute - 2 violations

element must have a lang attribute - 4 violations

Images must have alternate text - 3 violations
Form elements must have labels 1 violation

@foxpcteam
Copy link
Author

HI @joscha ,
did you check it?

@joscha
Copy link
Member

joscha commented Apr 27, 2017

I had a short look, didn't check out the FF plugin itself though, all should come from https://github.com/dequelabs/axe-core/ - I think the difference might be the version - runner-axe uses https://github.com/dequelabs/axe-core/blob/master/doc/API.md#api-name-axea11ycheck - have you tried to update the code in index.js to use the new .run API? As you can see in the runner code, it is very simple, there is no special logic other than a direct call to .a11ycheck and passing along any options you might have given.

@joscha
Copy link
Member

joscha commented Apr 27, 2017

Also, can you have a look at running your code with debugging enabled as described here: https://github.com/crawlkit/crawlkit#debugging please? Just to make sure its not opening a different website or gets redirected, obstructed by a firewall, etc. and that's why the results are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants