Dangerfile cannot be compiled when using Xcode 16 #615

AndrewVebster · 2024-08-06T14:52:40Z

Hi 👋

When running danger-swift on a device with Xcode 16 the command fails with this error:

  7 | let danger = Danger()
    |              `- error: cannot call value of non-function type 'module<Danger>'

Running locally and on Bitrise - the error is the same.
Using this command:
swift run danger-swift local --cwd ../../
or this on CI
swift run danger-swift ci --no-publish-check -f --cwd ../../

I believe my setup is pretty standard:

Danger installed via SPM without any additional plugins
Simple Dangerfile - I removed everything a left only this 👇

import Danger
import Foundation

let danger = Danger()

⚠️ The same setup works fine with Xcode 15.

Environment

Xcode 16.0 beta 4 (16A5211f)
Running locally on macOS 15.0 Beta (24A5298h)
or running on Bitrise CI, the error is the same

Other Info

My assumption is that import Danger doesn't work as expected. Because compiler doesn't see other types and functions. For example, fail function:

19 |         fail(message: "Message", file: $0, line: 2)
    |         `- error: cannot find 'fail' in scope

Or DangerDSL.

I tried installing danger-swift from brew instead of SMP when running on CI but the result is the same.

Full command & result

swift run danger-swift local --cwd ../../ 
Building for debugging...
[1/1] Write swift-version-39B54973F684ADAB.txt
Build of product 'danger-swift' complete! (0.34s)
(node:51429) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
/var/folders/gj/tj6dnp8d1s71sp3sj5tlkh000000gn/T/danger/B52A4EC1-CE42-45E0-955E-3E50FB477100/_tmp_dangerfile.swift:7:14: error: cannot call value of non-function type 'module<Danger>'
  5 | import Foundation
  6 | 
  7 | let danger = Danger()
    |              `- error: cannot call value of non-function type 'module<Danger>'
  8 | 
  9 | 

ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/gj/tj6dnp8d1s71sp3sj5tlkh000000gn/T/danger/B52A4EC1-CE42-45E0-955E-3E50FB477100/danger-response.json

Danger: ⅹ Failing the build, there is 1 fail.
## Failures
`danger-swift` failed.
## Markdowns
### Log


/var/folders/gj/tj6dnp8d1s71sp3sj5tlkh000000gn/T/danger/B52A4EC1-CE42-45E0-955E-3E50FB477100/_tmp_dangerfile.swift:7:14: error: cannot call value of non-function type 'module<Danger>'
  5 | import Foundation
  6 | 
  7 | let danger = Danger()
    |              `- error: cannot call value of non-function type 'module<Danger>'
  8 | 
  9 | 
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/gj/tj6dnp8d1s71sp3sj5tlkh000000gn/T/danger/B52A4EC1-CE42-45E0-955E-3E50FB477100/danger-response.json

My Package.swift

// swift-tools-version: 5.9
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "DangerDependencies",
    products: [
        .library(
            name: "DangerDeps",
            type: .dynamic,
            targets: ["DangerDependencies"]),
    ],
    dependencies: [
        .package(url: "https://github.com/danger/swift.git", from: "3.18.1"),
    ],
    targets: [
        .target(
            name: "DangerDependencies",
            dependencies: [
                .product(name: "Danger", package: "swift")
            ]
        ),
    ]
)

My Dangerfile.swift

import Danger
import Foundation

let danger = Danger()

The text was updated successfully, but these errors were encountered:

radude89 · 2024-09-04T08:30:05Z

I could reproduce the problem with Xcode 16 beta 6 (16A5230g). Do we have any updates about this issue or a possible workaround? Thank you!

marcomasser · 2024-09-10T07:46:01Z

I just ran into this issue with Xcode 16.0 RC 1 (16A242). Is there any update on this?

oronbz · 2024-09-12T08:59:31Z

Same here with RC

f-meloni · 2024-09-16T15:07:41Z

let danger = Danger()
    |              `- error: cannot call value of non-function type 'module<Danger>'

Is it possible that it thinks you are referring to the Danger module and not the Danger function?
Would Danger.Danger() work?

marcomasser · 2024-09-16T15:13:44Z

Unfortunately, this doesn’t solve the issue:

$ swift run danger-swift pr https://github.com/…
Building for debugging...
[1/1] Write swift-version--6E9C300FE98E0E3E.txt
Build of product 'danger-swift' complete! (0.34s)
Starting Danger PR on …
/var/folders/vk/v4gx2v6x4972w9v5r1xggx000000gn/T/_tmp_dangerfile.swift:13:14: error: module 'Danger' has no member named 'Danger'
 11 | import Danger
 12 | 
 13 | let danger = Danger.Danger()
    |              `- error: module 'Danger' has no member named 'Danger'
 14 | let pullRequest = danger.github.pullRequest
 15 | let git = danger.git

CreativeSpaghetti · 2024-09-17T18:36:37Z

This might help. Got it working locally.
Assuming you're workng on MacOS, have XCode 16 installed and danger-swift via brew

# Clone danger/swift repo into temp directory
mkdir mydanger
cd mydanger
git clone https://github.com/danger/swift.git
cd swift

# build with your current SDK in your current XCode (ie XCode 16)
swift build --configuration release --sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk

# Copy to replace files in your old brew setup
sudo cp .build/arm64-apple-macosx/release/danger-swift /opt/homebrew/opt/danger-swift/bin/danger-swift
sudo cp .build/arm64-apple-macosx/release/Modules/Danger.swiftmodule /opt/homebrew/lib/danger/Danger.swiftmodule
sudo cp .build/arm64-apple-macosx/release/Modules/DangerShellExecutor.swiftmodule /opt/homebrew/lib/danger/DangerShellExecutor.swiftmodule
sudo cp .build/arm64-apple-macosx/release/Modules/Logger.swiftmodule /opt/homebrew/lib/danger/Logger.swiftmodule
sudo cp .build/arm64-apple-macosx/release/Modules/OctoKit.swiftmodule /opt/homebrew/lib/danger/OctoKit.swiftmodule
sudo cp .build/arm64-apple-macosx/release/Modules/RequestKit.swiftmodule /opt/homebrew/lib/danger/RequestKit.swiftmodule

# cleanup
cd ../..
rm -fr mydanger

# run danger-swift
danger-swift local --text-only --verbose

marcomasser · 2024-09-18T07:03:27Z

That’s interesting! So if re-building Danger Swift using Xcode 16 fixes the issue, I guess a new release of Danger that was built using Xcode 16 could resolve this?

CreativeSpaghetti · 2024-09-18T07:12:04Z

That’s interesting! So if re-building Danger Swift using Xcode 16 fixes the issue, I guess a new release of Danger that was built using Xcode 16 could resolve this?

Nope, just tested it with 3.19.1, not working for me. So still need to stick to that workaround so far.

marcomasser · 2024-09-18T07:23:19Z

That’s interesting! So if re-building Danger Swift using Xcode 16 fixes the issue, I guess a new release of Danger that was built using Xcode 16 could resolve this?

Nope, just tested it with 3.19.1, not working for me. So still need to stick to that workaround so far.

3.19.1 also doesn’t work for me but I also don’t know what version of Xcode was used to build that.

f-meloni · 2024-09-18T08:05:49Z

Danger is built in your machine. When you install it via brew it runs the install script in your machine.
It uses the Xcode you selected with xcode-select to build.
Same for SPM, it builds Danger and runs it in your machine with the selected Xcode.

marcomasser · 2024-09-18T08:17:25Z

Ah right, thanks for the clarification! But that just makes it more interesting that what @CreativeSpaghetti posted works for them 🤔

f-meloni · 2024-09-18T08:19:41Z

Indeed, it that is the fix, then Danger should work if you force a brew install and have Xcode 16 selected 🤔

marcomasser · 2024-09-18T08:25:39Z

Unfortunately, that does not seem to change anything 😞

> xcode-select -p
/Applications/Xcode-16.0.app/Contents/Developer
> brew reinstall danger/tap/danger-swift
==> Fetching danger/tap/danger-swift
==> Downloading https://github.com/danger/danger-swift/archive/3.19.1.tar.gz
Already downloaded: /Users/marco/Library/Caches/Homebrew/downloads/313490d738c01aae624c4dda88a017dcebd16c6123b27f341b593be2c01206e9--swift-3.19.1.tar.gz
==> Reinstalling danger/tap/danger-swift 
==> make install PREFIX=/opt/homebrew/Cellar/danger-swift/3.19.1
🍺  /opt/homebrew/Cellar/danger-swift/3.19.1: 8 files, 3.9MB, built in 31 seconds
==> Running `brew cleanup danger-swift`...
> swift run danger-swift pr https://github.com/…
[…]
Build of product 'danger-swift' complete! (5.86s)
Starting Danger PR on …
/var/folders/vk/v4gx2v6x4972w9v5r1xggx000000gn/T/_tmp_dangerfile.swift:13:14: error: cannot call value of non-function type 'module<Danger>'
 11 | import Danger
 12 | 
 13 | let danger = Danger()
    |              `- error: cannot call value of non-function type 'module<Danger>'
 14 | let pullRequest = danger.github.pullRequest
 15 | let git = danger.git
[…]

CreativeSpaghetti · 2024-09-18T08:41:07Z

Unfortunately, that does not seem to change anything 😞

> xcode-select -p
/Applications/Xcode-16.0.app/Contents/Developer
> brew reinstall danger/tap/danger-swift
==> Fetching danger/tap/danger-swift
==> Downloading https://github.com/danger/danger-swift/archive/3.19.1.tar.gz
Already downloaded: /Users/marco/Library/Caches/Homebrew/downloads/313490d738c01aae624c4dda88a017dcebd16c6123b27f341b593be2c01206e9--swift-3.19.1.tar.gz
==> Reinstalling danger/tap/danger-swift 
==> make install PREFIX=/opt/homebrew/Cellar/danger-swift/3.19.1
🍺  /opt/homebrew/Cellar/danger-swift/3.19.1: 8 files, 3.9MB, built in 31 seconds
==> Running `brew cleanup danger-swift`...
> swift run danger-swift pr https://github.com/…
[…]
Build of product 'danger-swift' complete! (5.86s)
Starting Danger PR on …
/var/folders/vk/v4gx2v6x4972w9v5r1xggx000000gn/T/_tmp_dangerfile.swift:13:14: error: cannot call value of non-function type 'module<Danger>'
 11 | import Danger
 12 | 
 13 | let danger = Danger()
    |              `- error: cannot call value of non-function type 'module<Danger>'
 14 | let pullRequest = danger.github.pullRequest
 15 | let git = danger.git
[…]

tried that brew reinstall danger-swift too, with Xcode 16 installed and selected, it did not help. Still needed to make a clean build and then replace the binaries.

skydivedan · 2024-09-18T13:26:30Z

Don't know if this helps, but I'm using Danger in CircleCI. I specify 3.19.1 in the Package.swift file. Xcode 16 is the only Xcode that is installed. I get a long list of errors. One of them looks like this:

/Users/distiller/project/DangerDeps/.build/debug/SwiftFormat-tool.build/module.modulemap:1:8: error: redefinition of module 'SwiftFormat'
1 | module SwiftFormat {
  |        `- error: redefinition of module 'SwiftFormat'
2 |     header "/Users/distiller/project/DangerDeps/.build/arm64-apple-macosx/debug/SwiftFormat-tool.build/SwiftFormat-Swift.h"
3 |     requires objc

Anyway, just wanted to give some more details. Hope this helps.

Ph1Doc · 2024-09-21T00:25:07Z

The same problem with Dangerfile

/_tmp_dangerfile.swift:3:22: error: cannot call value of non-function type 'module<Danger>'
▸ 1 | import Danger
▸ 2 |
▸ 3 | private let danger = Danger()
▸ |                      `- error: cannot call value of non-function type 'module<Danger>'
▸ 4 |

jwelton · 2024-09-24T08:58:11Z

I'm facing the same issue. Did anyone find a solution for this? I'm using SPM.

The same problem with Dangerfile

/_tmp_dangerfile.swift:3:22: error: cannot call value of non-function type 'module<Danger>'
▸ 1 | import Danger
▸ 2 |
▸ 3 | private let danger = Danger()
▸ |                      `- error: cannot call value of non-function type 'module<Danger>'
▸ 4 |

Arafo · 2024-09-27T06:33:07Z

There seems to be a name conflict between the target Danger and the function Danger()

swift/Sources/Danger/Danger.swift

Lines 90 to 93 in a3c659e

    
           // swiftlint:disable:next identifier_name 
        
           public func Danger() -> DangerDSL { 
        
               DangerRunner.shared.dsl 
        
           }

I guess that's why the error says cannot call value of non-function type 'module'.

Not sure why this is happening now with Xcode 16 / Swift 6 but I got it working renaming the function Danger() to Danger1() 🙃
Arafo@c075cdc

Renaming the target should work as well

marcomasser · 2024-09-27T07:33:59Z

Thanks for the hint! I forked Danger and renamed all occurrences of the Danger() function as you suggested, but that unfortunately leads to an error in the SwiftFormat dependency, but only when trying to run Danger in my project’s repository:

> swift run danger-swift pr https://github.com/[…]
[…]
Building for debugging...
[55/55] Applying danger-swift
Build of product 'danger-swift' complete! (5.26s)
Starting Danger PR on […]
[…]/Danger/.build/debug/SwiftFormat-tool.build/module.modulemap:1:8: error: redefinition of module 'SwiftFormat'
1 | module SwiftFormat {
  |        `- error: redefinition of module 'SwiftFormat'
2 |     header "[…]/Danger/.build/arm64-apple-macosx/debug/SwiftFormat-tool.build/SwiftFormat-Swift.h"
3 |     requires objc

[…]/Danger/.build/debug/SwiftFormat.build/module.modulemap:1:8: note: previously defined here
1 | module SwiftFormat {
  |        `- note: previously defined here
2 |     header "[…]/Danger/.build/arm64-apple-macosx/debug/SwiftFormat.build/SwiftFormat-Swift.h"
3 |     requires objc

I tried to pin this dependency to an earlier version to check if it works then, but didn’t succeed in doing that.

Regardless, the naming clash really does seem to be an issue. Good find!

Arafo · 2024-09-27T09:27:06Z

@marcomasser did you try building for release?

marcomasser · 2024-09-27T09:39:10Z

Yes, same result:

> swift run -c release danger-swift pr https://github.com/[…]
Building for production...
[1/1] Write swift-version-7BB6C6736DFA3E78.txt
Build of product 'danger-swift' complete! (0.17s)
Starting Danger PR on […]
[…]/Danger/.build/debug/SwiftFormat-tool.build/module.modulemap:1:8: error: redefinition of module 'SwiftFormat'
1 | module SwiftFormat {
  |        `- error: redefinition of module 'SwiftFormat'
2 |     header "[…]/Danger/.build/arm64-apple-macosx/debug/SwiftFormat-tool.build/SwiftFormat-Swift.h"
3 |     requires objc

[…]/Danger/.build/debug/SwiftFormat.build/module.modulemap:1:8: note: previously defined here
1 | module SwiftFormat {
  |        `- note: previously defined here
2 |     header "[…]/Danger/.build/arm64-apple-macosx/debug/SwiftFormat.build/SwiftFormat-Swift.h"
3 |     requires objc

Update: It does not make a difference whether the isDevelop in Danger’s Package.swift is set to true or false. If it’s false, Danger doesn’t declare the dependency on SwiftFormat, but it will still depend on OctoKit, which in turn depends on SwiftFormat.

Arafo · 2024-09-27T09:56:47Z

Interesting, do you know from where SwiftFormat dependency is coming from?

EDIT: nvm, I was able to reproduce adding SwiftFormat to my Package.swift file

marcomasser · 2024-09-27T10:15:11Z

It seems OctoKit is pulling that in.

ivanopcode · 2024-10-02T08:44:00Z

Thanks for the hint! I forked Danger and renamed all occurrences of the Danger() function as you suggested, but that unfortunately leads to an error in the SwiftFormat dependency, but only when trying to run Danger in my project’s repository:

Have you tried renaming the product/target to 'DangerSmth'? Looks like that should help.

marcomasser · 2024-10-02T10:32:36Z

Have you tried renaming the product/target to 'DangerSmth'? Looks like that should help.

Thanks for the suggestion. I tried renaming the "Danger" target in my fork and then pull that in, but it didn’t help. I just get the same error about SwiftFormat.

I think renaming either the Danger target or the global function both should work and the error about SwiftFormat is just the next issue that is probably not related to this anymore. I just don’t understand why it should be a problem that OctoKit depends on SwiftLint 🤷‍♂️

Anyway, I looked into this some more and noticed that OctoKit only declares the dependency on SwiftFormat, but doesn’t actually use it. So I forked OctoKit and commented out that line and now this error when running Danger is gone – just for the next one to appear 😩

So now I’m here:

> swift run danger-swift pr https://github.com/…
[…]
Building for debugging...
[41/41] Emitting module Runner
Build of product 'danger-swift' complete! (1.60s)
Starting Danger PR on IdeasOnCanvas/MindNode#11360
warning: 'octokit.swift': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
    …/Danger/.build/checkouts/octokit.swift/OctoKit/Info.plist

/var/folders/vk/v4gx2v6x4972w9v5r1xggx000000gn/T/danger/E804D871-2424-4A8D-82DC-D1C6F8A4037C/_tmp_dangerfile.swift:13:14: error: cannot find 'makeDangerDSL' in scope
 11 | import Danger
 12 | 
 13 | let danger = makeDangerDSL() // Renamed, original was: Danger()
    |              `- error: cannot find 'makeDangerDSL' in scope
 14 | let pullRequest = danger.github.pullRequest
 15 | let git = danger.git


/var/folders/vk/v4gx2v6x4972w9v5r1xggx000000gn/T/danger/E804D871-2424-4A8D-82DC-D1C6F8A4037C/_tmp_dangerfile.swift:70:1: error: cannot find 'SwiftLint' in scope
 68 | // MARK: - Run swiftlint
 69 | 
 70 | SwiftLint.lint(inline: true, configFile: ".swiftlint.yml")
    | `- error: cannot find 'SwiftLint' in scope
 71 | 
 72 | // MARK: - Private Extensions


/var/folders/vk/v4gx2v6x4972w9v5r1xggx000000gn/T/danger/E804D871-2424-4A8D-82DC-D1C6F8A4037C/_tmp_dangerfile.swift:74:19: error: cannot find type 'Git' in scope
 72 | // MARK: - Private Extensions
 73 | 
 74 | private extension Git {
    |                   `- error: cannot find type 'Git' in scope
 75 | 
 76 |     var hasSourcesModifications: Bool {

/var/folders/vk/v4gx2v6x4972w9v5r1xggx000000gn/T/danger/E804D871-2424-4A8D-82DC-D1C6F8A4037C/_tmp_dangerfile.swift:119:19: error: cannot find type 'GitHub' in scope
117 | }
118 | 
119 | private extension GitHub.PullRequest {
    |                   `- error: cannot find type 'GitHub' in scope
120 | 
121 |     var hasMilestone: Bool { self.milestone != nil }

ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/vk/v4gx2v6x4972w9v5r1xggx000000gn/T/danger/E804D871-2424-4A8D-82DC-D1C6F8A4037C/danger-response.json
[…]

makeDangerDSL() is my renamed version of Danger() to fix the naming clash. So now all the public symbols from the Danger module seem to be missing, see also SwiftLint and GitHub. I’m digging further…

Arafo · 2024-10-09T09:08:02Z

After many tries I got it working somehow

First, I forked SwiftFormat and OctoKit

In SwiftFormat fork I commented out this line
https://github.com/nicklockwood/SwiftFormat/blob/ed75a316f2f2868b9181ae8d1c7182bf8d97f269/Package%40swift-5.6.swift#L9

Then, in OctoKit fork, I just switch SwiftFormat to point to my fork in the Package.swift file.

This avoids symbols duplication, I'm not sure why this is a thing now with Swift 6 but I observed that I was getting two different build folders for SwiftFormat CommandLineTool target, the usual one and another one ending with -tool.build. I didn't found anything about this but this message in the Swift forums.

Now, with these 2 forks, I was able to override the version used in my Danger setup adding this to my Package.swift dependency list:
.package( url: "https://github.com/myfork/octokit.swift", branch: "main" )
I know this is not the ideal way to "override" dependencies but it works for now.

Now, the only way I found to properly link Danger is specifying both arm64 and x86_64 architectures, when building:
swift build -c release --arch arm64 --arch x86_64

Then the usual Danger dynamic lib renaming:
cp .build/apple/Products/Release/libDangerDeps.dylib .build/apple/Products/Release/libDanger.dylib

And last, run the danger-swift binary:
swift run -c release --arch arm64 --arch x86_64 danger-swift ci

This works for me but I have no clue why specifying both arm and Intel archs seems to do the trick.

f-meloni · 2024-10-14T08:25:04Z

I have tested @abhi-m-simformsolutons's change from #626 and it seemed to fix all the issues.

I have released version 3.20.0, let me know if it works!

marcomasser · 2024-10-14T08:59:04Z

Yes! 🥳
This now works fine without any of the modifications discussed in this issue. Thank you 👏

f-meloni · 2024-10-14T09:04:13Z

Good! I will close this issue then, feel free to re open it if needed

oronbz · 2024-10-14T12:35:08Z

@f-meloni Still experiencing this on the new version:

danger-swift 3.18.1 is already installed but outdated (so it will be upgraded).
==> Fetching danger/tap/danger-swift
==> Downloading https://github.com/danger/danger-swift/archive/3.20.0.tar.gz
==> Downloading from https://codeload.github.com/danger/swift/tar.gz/refs/tags/3.20.0
==> Upgrading danger/tap/danger-swift
  3.18.1 -> 3.20.0 
==> make install PREFIX=/opt/homebrew/Cellar/danger-swift/3.20.0
🍺  /opt/homebrew/Cellar/danger-swift/3.20.0: 8 files, 3.9MB, built in 39 seconds
Warning: HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK is set: not checking for outdated
dependents or dependents with broken linkage!
+ echo '⚠️ DANGER ! :)'
⚠️ DANGER ! :)
+ danger-swift ci
/var/folders/b8/9zt_tx3s1y37nzh_cs991xyc0000gn/T/danger/FFA7F08D-5ACD-4F14-9B3C-8765A95A10D2/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
 1 [REDACTED] import Danger
   [REDACTED]        `- error: no such module 'Danger'
 2 [REDACTED] import Foundation
 3 [REDACTED] 
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/b8/9zt_tx3s1y37nzh_cs991xyc0000gn/T/danger/FFA7F08D-5ACD-4F14-9B3C-8765A95A10D2/danger-response.json
Failing the build, there is 1 fail.
Feedback: https://github.com/gtforge/gtforge-iphone/pull/3919#issuecomment-2411101472
ERROR: Could not get the results JSON file at /var/folders/b8/9zt_tx3s1y37nzh_cs991xyc0000gn/T/danger/FFA7F08D-5ACD-4F14-9B3C-8765A95A10D2/danger-response.json

f-meloni · 2024-10-14T12:38:06Z

@oronbz this is not using danger-swift from Package.swift, but from brew, I'm working on a fix for that as well, but is not ready yet

oronbz · 2024-10-14T12:40:58Z

Got it, will wait (: thanks!

f-meloni · 2024-10-14T12:42:05Z

@oronbz this is the diff that should be able to fix the issue #627

f-meloni · 2024-10-14T13:31:49Z

@oronbz you can try now, it should be working

oronbz · 2024-10-14T14:14:15Z

Same @f-meloni :(

Warning: swiftlint 0.57.0 is already installed and up-to-date.
To reinstall 0.57.0, run:
  brew reinstall swiftlint
+ brew install danger-swift
danger-swift 3.18.1 is already installed but outdated (so it will be upgraded).
==> Fetching danger/tap/danger-swift
==> Downloading https://github.com/danger/danger-swift/archive/3.20.1.tar.gz
==> Downloading from https://codeload.github.com/danger/swift/tar.gz/refs/tags/3.20.1
==> Upgrading danger/tap/danger-swift
  3.18.1 -> 3.20.1 
==> make install PREFIX=/opt/homebrew/Cellar/danger-swift/3.20.1
🍺  /opt/homebrew/Cellar/danger-swift/3.20.1: 8 files, 3.9MB, built in 47 seconds
Warning: HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK is set: not checking for outdated
dependents or dependents with broken linkage!
+ echo '⚠️ DANGER ! :)'
⚠️ DANGER ! :)
+ danger-swift ci
/var/folders/b8/9zt_tx3s1y37nzh_cs991xyc0000gn/T/danger/A2174C8B-B237-46B1-9154-A4BF42A901DA/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
 1 [REDACTED] import Danger
   [REDACTED]        `- error: no such module 'Danger'
 2 [REDACTED] import Foundation
 3 [REDACTED] 
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/b8/9zt_tx3s1y37nzh_cs991xyc0000gn/T/danger/A2174C8B-B237-46B1-9154-A4BF42A901DA/danger-response.json
Failing the build, there is 1 fail.
Feedback: https://github.com/gtforge/gtforge-iphone/pull/3919#issuecomment-2411101472
ERROR: Could not get the results JSON file at /var/folders/b8/9zt_tx3s1y37nzh_cs991xyc0000gn/T/danger/A2174C8B-B237-46B1-9154-A4BF42A901DA/danger-response.json

oronbz · 2024-10-14T14:17:54Z

@f-meloni Let me know if I should keep comment updates here or on the other open issue: #623

abhi-m-simformsolutons mentioned this issue Oct 10, 2024

Fix module path for Swift 6 builds #626

Merged

f-meloni closed this as completed Oct 14, 2024

f-meloni mentioned this issue Oct 14, 2024

Danger 3.19.1 is not working on Xcode 16. #623

Closed

Dangerfile cannot be compiled when using Xcode 16 #615

Dangerfile cannot be compiled when using Xcode 16 #615

Comments

AndrewVebster commented Aug 6, 2024

Environment

Other Info

radude89 commented Sep 4, 2024

marcomasser commented Sep 10, 2024

oronbz commented Sep 12, 2024

f-meloni commented Sep 16, 2024

marcomasser commented Sep 16, 2024

CreativeSpaghetti commented Sep 17, 2024 • edited Loading

marcomasser commented Sep 18, 2024

CreativeSpaghetti commented Sep 18, 2024

marcomasser commented Sep 18, 2024

f-meloni commented Sep 18, 2024 • edited Loading

marcomasser commented Sep 18, 2024

f-meloni commented Sep 18, 2024

marcomasser commented Sep 18, 2024

CreativeSpaghetti commented Sep 18, 2024 • edited Loading

skydivedan commented Sep 18, 2024

Ph1Doc commented Sep 21, 2024

jwelton commented Sep 24, 2024

Arafo commented Sep 27, 2024

marcomasser commented Sep 27, 2024 • edited Loading

Arafo commented Sep 27, 2024

marcomasser commented Sep 27, 2024 • edited Loading

Arafo commented Sep 27, 2024 • edited Loading

marcomasser commented Sep 27, 2024

ivanopcode commented Oct 2, 2024

marcomasser commented Oct 2, 2024 • edited Loading

Arafo commented Oct 9, 2024

f-meloni commented Oct 14, 2024

marcomasser commented Oct 14, 2024

f-meloni commented Oct 14, 2024

oronbz commented Oct 14, 2024

f-meloni commented Oct 14, 2024

oronbz commented Oct 14, 2024

f-meloni commented Oct 14, 2024

f-meloni commented Oct 14, 2024

oronbz commented Oct 14, 2024

oronbz commented Oct 14, 2024

CreativeSpaghetti commented Sep 17, 2024 •

edited

Loading

f-meloni commented Sep 18, 2024 •

edited

Loading

CreativeSpaghetti commented Sep 18, 2024 •

edited

Loading

marcomasser commented Sep 27, 2024 •

edited

Loading

marcomasser commented Sep 27, 2024 •

edited

Loading

Arafo commented Sep 27, 2024 •

edited

Loading

marcomasser commented Oct 2, 2024 •

edited

Loading