Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres binding does not validate the connection on init #3594

Open
famarting opened this issue Nov 11, 2024 · 3 comments
Open

Postgres binding does not validate the connection on init #3594

famarting opened this issue Nov 11, 2024 · 3 comments
Labels
kind/enhancement New feature or request

Comments

@famarting
Copy link
Contributor

Describe the feature

The postgres state store implementation does validate the connection to the database on init by performing a ping request.
See here https://github.com/dapr/components-contrib/blob/main/state/postgresql/v2/postgresql.go#L110

However the postgres binding does not validate the connection https://github.com/dapr/components-contrib/blob/main/bindings/postgres/postgres.go#L58

It would make sense to update the postgres binding to also validate the connection on init

Release Note

RELEASE NOTE: UPDATE Postgres binding, validate connection on init

@famarting famarting added the kind/enhancement New feature or request label Nov 11, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 11, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
@famarting
Copy link
Contributor Author

bump

@yaron2 yaron2 reopened this Dec 18, 2024
@github-actions github-actions bot removed the stale label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants