Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mv disjoint endpoint field to built-in aws auth profile metadata #3622

Open
sicoyle opened this issue Dec 4, 2024 · 1 comment
Open

mv disjoint endpoint field to built-in aws auth profile metadata #3622

sicoyle opened this issue Dec 4, 2024 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@sicoyle
Copy link
Contributor

sicoyle commented Dec 4, 2024 •
edited
Loading

Describe the feature

The Dapr docs show endpoint as an optional field.
image

It is included in some of the AWS components, but not all. It should be moved to be part of the built-in aws auth profile fields here: https://github.com/dapr/components-contrib/blob/main/.build-tools/builtin-authentication-profiles.yaml and something that can be optionally added for all aws components.

This would be a good first time issue. Please, someone add that label.

Release Note

RELEASE NOTE:
@sicoyle sicoyle added the kind/enhancement New feature or request label Dec 4, 2024
@sicoyle
Copy link
Contributor Author

sicoyle commented Dec 4, 2024

looks like it's only used by these aws components atm: s3, dynamodb, kinesis, secretmanager, snssqs

https://github.com/search?q=repo%3Adapr%2Fcomponents-contrib%20name%3A%20endpoint&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sicoyle