Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC client used in SDK #1430

Open
WhitWaldo opened this issue Dec 16, 2024 · 4 comments
Open

Update gRPC client used in SDK #1430

WhitWaldo opened this issue Dec 16, 2024 · 4 comments
Assignees
Labels
area/client good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Milestone

Comments

@WhitWaldo
Copy link
Contributor

Describe the feature

Per the blog post here the gRPC library used in the SDK has been deprecated in favor of a modern version that is fully C#-based instead of an interop wrapper around a C library. The transition to this new SDK should be performed as part of the v1.16 release.

The various options are available in this GitHub repo and I'm tentatively thinking we should opt to use Grpc.Net.ClientFactory as the various client builders use IHttpClientFactory under the hood as of the v1.15 release.

Release Note

RELEASE NOTE: UPDATE Update gRPC dependency used in all Dapr clients

@WhitWaldo WhitWaldo added kind/enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers area/client labels Dec 16, 2024
@WhitWaldo WhitWaldo added this to the v1.16 milestone Dec 16, 2024
@WhitWaldo
Copy link
Contributor Author

It looks like this migration may have already happened as I already see that the various packages are updated across the board. Confusingly, they retained the same Grpc.Core namespace, which is what threw me off here. It's worth poking around to see if there's any remaining work that can be done to improve gRPC connections, but this may be already taken as far as it should.

@WhitWaldo WhitWaldo self-assigned this Dec 21, 2024
@jev-e
Copy link
Contributor

jev-e commented Dec 31, 2024

As I brought this up and we have spoken about this before I am happy to complete this investigation (if it is not already underway), and get a resolution on any work that needs doing.

@WhitWaldo
Copy link
Contributor Author

WhitWaldo commented Dec 31, 2024

@jev-e Sure, if you see anything that needs doing, have at it, but no rush as I'll wait until after the 1.15 release to merge it.

@jev-e
Copy link
Contributor

jev-e commented Dec 31, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants