Workflows alignment with Spring Boot (Dependency Injection for Workflows and Activities) #1170
+249
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaboy
force-pushed
the
workflows-1164
branch
from
5ed82a7 to
75015dc
Compare
artur-ciocanu
approved these changes
Dec 7, 2024
There was a problem hiding this comment.
@salaboy awesome job! I have left some comments mostly styling, however I think you should adjust the DaprWorkflowsConfig a little. I have used all the suggestion that I have provided, ran the tests and everything is 🟢, so I think you can safely apply them and open a PR.
I think the auto-configuration you have added provides enough value fort Spring Boot users. We can add bells and whistles later.
...gure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientAutoConfiguration.java
Show resolved
Hide resolved
...gure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientAutoConfiguration.java
Show resolved
Hide resolved
dapr-spring/dapr-spring-workflows/src/main/java/io/dapr/spring/workflows/Operation.java
Outdated
Show resolved
Hide resolved
dapr-spring/dapr-spring-workflows/src/main/java/io/dapr/spring/workflows/Workflow.java
Outdated
Show resolved
Hide resolved
...gure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientAutoConfiguration.java
Show resolved
Hide resolved
...e/src/test/java/io/dapr/spring/boot/autoconfigure/client/DaprWorkflowsRegistrationTests.java
Show resolved
Hide resolved
...onfigure/src/test/java/io/dapr/spring/boot/autoconfigure/client/WorkflowTestApplication.java
Show resolved
Hide resolved
...dapr-spring-workflows/src/main/java/io/dapr/spring/workflows/config/DaprWorkflowsConfig.java
Outdated
Show resolved
Hide resolved
...dapr-spring-workflows/src/main/java/io/dapr/spring/workflows/config/DaprWorkflowsConfig.java
Outdated
Show resolved
Hide resolved
|
I am a bit stuck on this: dapr/dapr#8341 |
salaboy
force-pushed
the
workflows-1164
branch
from
efaadb4 to
6227935
Compare
salaboy
changed the title
salaboy
force-pushed
the
workflows-1164
branch
2 times, most recently
from
80ff5e0 to
36f4f03
Compare
|
@artur-ciocanu @artursouza @cicoyle can you please review this PR? |
artur-ciocanu
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
@salaboy looks great a have left a tiny comment related to registerWorkflowsAndActivities method, I don't think it should be public, it is an internal method.
...ring-workflows/src/main/java/io/dapr/spring/workflows/config/DaprWorkflowsConfiguration.java
Show resolved
Hide resolved
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
* fix link Signed-off-by: Hannah Hunter <[email protected]> * fix one more link Signed-off-by: Hannah Hunter <[email protected]> * remove beta from Java SDK workflow Signed-off-by: Hannah Hunter <[email protected]> --------- Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: Artur Souza <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: Artur Souza <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: Artur Souza <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: Dapr Bot <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: Artur Souza <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
salaboy
force-pushed
the
workflows-1164
branch
from
5a2d6c2 to
da8049f
Compare
|
@artursouza and @cicoyle could you please review and approve. Thank you! |
|
Feedback from one of my highly experienced engineers who are looking forward to trying Workflows with Java :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This WIP PR contains the changes to align the workflow functionality with Spring Boot. The tasks described in #1164 are implemented in this PR.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1164
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: