You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently a few Dapr worflows related classes are "poorly" named and do not reflect the intent of the class. Also some classes are exposed to the public API, while it shouldn't.
Here are a few of the offenders:
Workflow abstract class - ideally it should be an interface and have "default" methods, for everything that is currently used
WorkflowActivity interface - it should be moved outside of runtime package, since it is part of the programming model
OrchestratorWrapper and ActivityWrapper - these should be renamed to WorkflowWrapper and WorkflowActivityWrapper respectively
WorkflowActivityContext - this should be an interface just like WorkflowContext and moved outside of runtime since it is part of the programming model.
DaprWorkflowContextImpl - should be renamed to DaprWorkflowContext and moved to runtime package since this is an internal implementation.
By implementing this proposal we will ensure that the classes that the developers have to interact with aka are part of the programming model are available in io.dapr.workflows while all the rest are pushed to runtime and also have proper names.
The text was updated successfully, but these errors were encountered:
Describe the proposal
Currently a few Dapr worflows related classes are "poorly" named and do not reflect the intent of the class. Also some classes are exposed to the public API, while it shouldn't.
Here are a few of the offenders:
Workflow
abstract class - ideally it should be an interface and have "default" methods, for everything that is currently usedWorkflowActivity
interface - it should be moved outside ofruntime
package, since it is part of the programming modelOrchestratorWrapper
andActivityWrapper
- these should be renamed toWorkflowWrapper
andWorkflowActivityWrapper
respectivelyWorkflowActivityContext
- this should be an interface just likeWorkflowContext
and moved outside ofruntime
since it is part of the programming model.DaprWorkflowContextImpl
- should be renamed toDaprWorkflowContext
and moved toruntime
package since this is an internal implementation.By implementing this proposal we will ensure that the classes that the developers have to interact with aka are part of the programming model are available in
io.dapr.workflows
while all the rest are pushed toruntime
and also have proper names.The text was updated successfully, but these errors were encountered: