Ensure Dapr workflows classes and interfaces have proper packages and visibility #1176
Conversation
|
@artursouza @salaboy and @cicoyle could you please take a look. Although there are a lot of files, all the changes are just moving classes around and renaming them. These are breaking changes for the users of Dapr Workflows, but I think it aligns better with the intended usage and programming model. Also since we are still in Please check it out and let me know your thoughts. Thank you! |
|
/lgtm ! please review and merge |
sdk-workflows/src/main/java/io/dapr/workflows/runtime/DaprWorkflowActivityContext.java
Outdated
Show resolved
Hide resolved
artur-ciocanu
force-pushed
the
gh-1175
branch
from
4d29987 to
23febff
Compare
|
@artursouza and @cicoyle I have addressed the comments. Could you please take another look? Thank you! |
|
/lgtm! |
|
@artursouza and @cicoyle whenever you have a chance could you please review and approve. Thank you! |
|
@artursouza and @cicoyle sorry to ping you again, could you please review and appprove. |
|
@artursouza and @cicoyle could you please review and approve. Thank you! |
|
/approve |
examples/src/main/java/io/dapr/examples/unittesting/DaprWorkflowExampleTest.java
Show resolved
Hide resolved
docs/dapr-sdk-workflows/io/dapr/workflows/runtime/class-use/WorkflowActivity.html
Outdated
Show resolved
Hide resolved
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
artur-ciocanu
force-pushed
the
gh-1175
branch
from
0f4b16c to
6b2b42c
Compare
|
@artursouza I have addressed the comments. Could you please approve. Thank you! |
|
@artursouza and @cicoyle whenever you have a chance could you please approve. Thank you! |
Description
Ensure Dapr workflows classes and interfaces have proper packages and visibility
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1175
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: