Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using alignments tool, it will crash when not supplying a faces folder. #490

Closed
Tvde1 opened this issue Sep 3, 2018 · 4 comments
Closed

Comments

@Tvde1
Copy link
Contributor

Tvde1 commented Sep 3, 2018

Note: Please only report bugs in this repository. Just because you are getting an error message does not automatically mean you have discovered a bug. If you don't have a lot of experience with this type of project, or if you need for setup help and other issues in using the faceswap tool, please refer to the faceswap-playground instead. The faceswap-playground is also an excellent place to ask questions and submit feedback.

Expected behavior

Command will run

Describe, in some detail, what you are trying to do and what the output is that you expect from the program.

Actual behavior

ERROR: The folder None could not be found

Describe, in some detail, what the program does instead. Be sure to include any error message or screenshots.

Steps to reproduce

Try it with this:

python G:\Repositories\faceswap\tools.py alignments -j missing-frames -a (PATH)  -fr (PATH) -o console -v

Here it crashes.

And if I do supply the -fc parameter, it exits because it is only valid with multi faces:

WARNING: The selected folder is not valid. Only folder set with '-fc' is supported for 'multi-faces'

Describe, in some detail, the steps you tried that resulted in the behavior described above.

Other relevant information

@torzdf
Copy link
Collaborator

torzdf commented Sep 3, 2018

Are you running latest commit? Just tested:

python tools.py alignments -j missing-frames -a /mnt/fakes/Masters/A/test/frames/25fps/alignments.json  -fr /mnt/fakes/Masters/A/test/frames/25fps  -o console -v
Please backup your data and/or test the tool you want to use with a smaller data set to make sure you understand how it works.

[ALIGNMENT DATA]
Alignments file exists at /mnt/fakes/Masters/A/test/frames/25fps/alignments.json
Destination format set to json
Loading alignments from /mnt/fakes/Masters/A/test/frames/25fps/alignments.json
32821 items loaded

[FRAMES DATA]
Folder exists at /mnt/fakes/Masters/A/test/frames/25fps
Loading file list from /mnt/fakes/Masters/A/test/frames/25fps
32821 items loaded

[CHECK FRAMES]
No frames were found meeting the criteria

@Tvde1
Copy link
Contributor Author

Tvde1 commented Sep 3, 2018

Hmm I'll check. On staging right?

@torzdf
Copy link
Collaborator

torzdf commented Sep 3, 2018

That was run from Master branch, but it wouldn't hurt to try staging. I've just tested staging myself, and it works.

@Tvde1
Copy link
Contributor Author

Tvde1 commented Sep 3, 2018

Ah it's been fixed on staging.

@Tvde1 Tvde1 closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants