Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-valued tags #109

Open
deluan opened this issue Oct 2, 2024 · 1 comment
Open

Support multi-valued tags #109

deluan opened this issue Oct 2, 2024 · 1 comment

Comments

@deluan
Copy link

deluan commented Oct 2, 2024

Hey @dhowden, have you considered supporting multi-valued tags? I started looking deeper in this package's codebase, and I think we could introduce it without breaking compatibility, by adding methods like

Values(name tag.Name) []string // this returns all values for a given tag, with a normalized (enum) name
Artists() []string
AlbumArtists() []string
Genres() []string
PictureTypes() []string
Pictures(type string) *Picture
RawValues() map[string][]any
...

Actually I just implemented Pictures/PictureTypes in my fork, to investigate/resolve an issue in my music server (navidrome/navidrome#3254).

Any thoughts? I can try to implement this if you feel it is a good addition.

By the way, here's my change implementing multiple pictures, but just for Vorbis for now: deluan@dfe5e6e

@dhowden
Copy link
Owner

dhowden commented Dec 22, 2024

Hey!

Great idea! I hesistate to make it an interface, since we then have to implement it on all the tag readers.

We can certainly start to add the methods to the different tag reader implementations and then see where we get to - what do you think?

P.S. I disabled github notifications a while back due to a noisy org I was added to :(. I'm behind now with most non-work correspondence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants