Redundant checks in ResponseCachingKeyProvider

[leeriorio]

There are two places, where Null-Conditional Operator (?.) using seems redundant in CreateStorageVaryByKey() method of internal class ResponseCachingKeyProvider.

aspnetcore/src/Middleware/ResponseCaching/src/ResponseCachingKeyProvider.cs

Line 99 in 6ae3ea3

var headersCount = varyByRules?.Headers.Count ?? 0;

and

aspnetcore/src/Middleware/ResponseCaching/src/ResponseCachingKeyProvider.cs

Line 126 in 6ae3ea3

if (varyByRules?.QueryKeys.Count > 0)

There is sufficient check of varyByRules value at the start of the method. Isn't it?

aspnetcore/src/Middleware/ResponseCaching/src/ResponseCachingKeyProvider.cs

Lines 80 to 83 in 6ae3ea3

	if (varyByRules == null)
	{
	throw new InvalidOperationException($"{nameof(CachedVaryByRules)} must not be null on the {nameof(ResponseCachingContext)}");
	}

Found by Linux Verification Center (linuxtesting.org) with SVACE.