You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I recently updated to a newer Version of docfx. When building metadata I use the dll's with their xml and now I get a ton of warnings for unresolved assemblies even though I included those in the references property in docfx.json. I realized my problem occurs only when the assemblies referenced are in a different folder.
I looked into the code a bit and could see Docfx currently uses the functionality of ILSpy to resolve all assembly references automaticly independent of the provided references. This works for all assemblies in the same directory and for assemblies of the framework. Assemblies from the references property are only added after this step (via Concat here) and the warnings are already printed in the Method GetReferenceAssemblies before.
The references provided should be included somehow in GetReferenceAssemblies. Also the class UniversalAssemblyResolver used for resolving the references provides an option for additional search paths via the method AddSearchDirectory. It should be pretty simple to provide those directories either as a seperate option or instead of the current format of the references option. What do you think?
To Reproduce
Steps to reproduce the behavior:
Provide an assembly for metadata and a dependend assembly in a different folder.
Provide the assembly in the different folder via the references property in docfx.json
start the metadata step
Expected behavior
No warning since the references assembly was provided.
Actual behavior
The following warning is printed:
warning: InvalidAssemblyReference: Unable to resolve assembly reference {FullyQualifiedAssemblyName}
Context (please complete the following information):
OS: Windows
Docfx version: 2.78.1
.NET version: .NET 8.0
Errors and warnings
warning: InvalidAssemblyReference: Unable to resolve assembly reference {FullyQualifiedAssemblyName}
The text was updated successfully, but these errors were encountered:
Describe the bug
I recently updated to a newer Version of docfx. When building metadata I use the dll's with their xml and now I get a ton of warnings for unresolved assemblies even though I included those in the
references
property in docfx.json. I realized my problem occurs only when the assemblies referenced are in a different folder.I looked into the code a bit and could see Docfx currently uses the functionality of ILSpy to resolve all assembly references automaticly independent of the provided references. This works for all assemblies in the same directory and for assemblies of the framework. Assemblies from the references property are only added after this step (via Concat here) and the warnings are already printed in the Method
GetReferenceAssemblies
before.The references provided should be included somehow in
GetReferenceAssemblies
. Also the classUniversalAssemblyResolver
used for resolving the references provides an option for additional search paths via the methodAddSearchDirectory
. It should be pretty simple to provide those directories either as a seperate option or instead of the current format of the references option. What do you think?To Reproduce
Steps to reproduce the behavior:
Expected behavior
No warning since the references assembly was provided.
Actual behavior
The following warning is printed:
warning: InvalidAssemblyReference: Unable to resolve assembly reference {FullyQualifiedAssemblyName}
Context (please complete the following information):
Errors and warnings
The text was updated successfully, but these errors were encountered: