Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update elixir-auth-github-demo to Phoenix 1.7 #29

Closed
2 tasks done
nelsonic opened this issue Dec 11, 2022 · 3 comments
Closed
2 tasks done

Chore: Update elixir-auth-github-demo to Phoenix 1.7 #29

nelsonic opened this issue Dec 11, 2022 · 3 comments
Assignees
@nelsonic
Labels
chore a tedious but necessary task often paying technical debt documentation Improvements or additions to documentation T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Dec 11, 2022 •
edited
Loading

I don't expect to this to take longer than T25M as and it should:

  • not have any superfluous depdendencies/features, e.g. no mail, postgres, dashboard etc.
  • should have the bare minimum code to make this work and nothing else.
@nelsonic nelsonic added documentation Improvements or additions to documentation T25m Time Estimate 25 Minutes chore a tedious but necessary task often paying technical debt technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Dec 11, 2022
@nelsonic nelsonic pinned this issue Dec 11, 2022
@nelsonic nelsonic self-assigned this Dec 11, 2022
@nelsonic nelsonic moved this to 🔖 Ready for Development in dwyl app kanban Aug 14, 2023
@nelsonic nelsonic mentioned this issue Aug 14, 2023
Closed
@nelsonic
Copy link
Member Author

Build failing on @dependabot PRs:
https://github.com/dwyl/elixir-auth-github-demo/actions/runs/6696640890/job/18194786113#step:8:123
image

@nelsonic nelsonic mentioned this issue Oct 31, 2023
Closed
nelsonic added a commit to dwyl/elixir-auth-github that referenced this issue Nov 6, 2023
@nelsonic
add catch-all HTTPoisonMock.post! for: dwyl/elixir-auth-github-demo#29
73312b1
nelsonic added a commit to dwyl/elixir-auth-github that referenced this issue Nov 6, 2023
@nelsonic
add test for HTTPoisonMock.post! for: dwyl/elixir-auth-github-demo#29
a6df38c
nelsonic added a commit to dwyl/elixir-auth-github that referenced this issue Nov 6, 2023
@nelsonic
bump version to release catch-all HTTPoisonMock.post! for: dwyl/elixi…
c62c19c 
…r-auth-github-demo#29
@nelsonic nelsonic mentioned this issue Nov 6, 2023
Merged
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
update instructions in README.md for Phoenix 1.7 #29
eb099fa
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
ignore unused components #29
5552d84
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
mix phx.new app -- create new Phoenix 1.7 app for #29
d300784
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
update README.md code & instructions #29
31d39d7
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
define github_auth_controller.ex #29
420a2b5
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
update code for phoenix 1.7 #29
8ae69cf
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
re-create test/app_web/controllers/github_auth_controller_test.exs #29
bc823ec
@nelsonic
Copy link
Member Author

nelsonic commented Nov 6, 2023

Update screenshots:

image image

https://elixir-auth-github-demo.fly.dev
image

image

nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
update screenshots in README.md #29
f7f1dad
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
mix format #29
52398f1
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
remove postgres from ci.yml as not used #29
10b29b0
nelsonic added a commit that referenced this issue Nov 6, 2023
@nelsonic
tidy README.md #29
486e8b8
asntc added a commit that referenced this issue Nov 6, 2023
@asntc
Merge pull request #96 from dwyl/phoenix-1.7.10-update-issue-#29
2bd0d45 
Phoenix 1.7.10 Update #29
@nelsonic
Copy link
Member Author

nelsonic commented Nov 6, 2023

Resolved by #96

@nelsonic nelsonic closed this as completed Nov 6, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready for Development to ✅ Done in dwyl app kanban Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
chore a tedious but necessary task often paying technical debt documentation Improvements or additions to documentation T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Nelson's List
Status: Done
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic