-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't execute certain blocks #18
Comments
I think this would be easy enough to do with something like
We could just take the processed markdown snippet and remove everything between those comments. |
Looks good but pretty verbose. Could we do a something that is easier to
type?
|
I suppose it'd be possible to just use |
Is there a way to have a bash pragma for the code block? Would mess up
github I assume though.
Like
bash @ignore
|
It seems to work... echo test
I'm not sure if it'd have wider negative implications though. |
Actually, @natew, this might actually work now. |
Don't think only for github. Those readmes are rendered in ton of places like NPM and such that rely on NPM registry to pull package readme.
|
It’s not about laziness. The whole point is to make it easy to read as well
when you’re editing. And to encourage people to write good documentation.
Could be better solutions but laziness isn’t the motivating force here.
|
It's hidden to the consumers anyway. And it is enough good and explicit. Verbose things some times are good thing. And i'm always for explicitness. It might be even more confusing for some people when it only depend on just Pragma feels good too, but we are not sure where these files are rendered. Oh, one more place - yarn's package site. |
It’s very clear what it ignores. It’s less verbose, but not less clear in
my opinion.
If it works already then it seems like a great option for many. If you want
to add a more verbose way, then I wouldn’t oppose. But this works for me
better than the verbose one for this use case.
For wanting to block off a big section I think the verbose one works too.
|
Could this not be done with a custom code block identifier, specifically for commenting?
|
It could, but you'd break syntax highlighting. |
We are not in javascript world and i don't understand why we should rely on pragmas or such, instead of just html comment as normally all will expect to work and it totally make sense to be that way.
"Please be explicit" is my motto. |
The pragma works as is because it's no longer recognized as a runnable type. Technically you could put anything there that wasn't a supported type and it would be preserved. In this case, Github at the very least still syntax highlights. That means there's no changes needed to support doing
I think it would be easy enough to add the html comment though. |
I just want to have some blocks be documenting how to use it, and then later define how it works.
So imagine that this would work (note the first blocks don't define a scripting language). Perhaps another thing like
<!-- ignore -->
would be better, so you can have it look like bash still.run
Run npm in any
apps/app
folder, defaults tostart
. To run every app in dev mode for example just do:which will end up running:
But you can run any arbitrary npm command inside any package here too by using the fourth argument. So,
maid run app build
would runnpm run build
insideapps/app
.The text was updated successfully, but these errors were encountered: