Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Azure Trusted signing #3767

Open
3 tasks done
bukacdan opened this issue Nov 21, 2024 · 3 comments · May be fixed by electron-forge/electron-forge-docs#210
Open
3 tasks done

Implement Azure Trusted signing #3767

bukacdan opened this issue Nov 21, 2024 · 3 comments · May be fixed by electron-forge/electron-forge-docs#210

Comments

@bukacdan
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

Microsoft introduced their own code signing platform in Azure, which simplifies the whole process and saves Win developers a ton of money.

It would be nice to have support for this in Forge. It has already been implemented in Electron builder (issue).

I don't think we can do use it in the existing forge pipeline, but correct me if I'm wrong.

Proposed solution

A trusted signing plugin, that would plug the signing logic into build and packaging steps.

Alternatives considered

A cookbook how to use Trusted signing with Forge manually.

Additional information

No response
@nikwen
Copy link

nikwen commented Nov 21, 2024 •
edited
Loading

Signing is done by https://github.com/electron/windows-sign.

If it doesn't support Azure Trusted Signing out of the box, you might use one of the following to make it work:

  • Specify custom signtool.exe options
  • Use the custom hooks feature described in the README

It might also make sense to open an issue in that repo.

@erickzhao erickzhao changed the title Implemet Azure Trusted signing Implement Azure Trusted signing Nov 22, 2024
@nikwen
Copy link

nikwen commented Nov 22, 2024

Also wanted to add this helpful tutorial that I stumbled across. I just used it to create a Trusted Signing account. It saved me hours.

Here's the section on signing executables using signtool.exe. I haven't yet signed an actual file. When I do, I'll try to update the @electron/forge and @electron/windows-sign docs with the proper instructions.

@nikwen nikwen linked a pull request Nov 29, 2024 that will close this issue
Open
@nikwen
Copy link

nikwen commented Nov 29, 2024

It took a lot of fiddling, but after 10+ hours, I got it to work. Documented in this PR: electron-forge/electron-forge-docs#210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: document Azure Trusted Signing workflow nikwen/electron-forge-docs
2 participants
@nikwen @bukacdan