Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron tries to run Redhat-specific tools when not using Redhat #3772

Open
3 tasks done
DrHyde opened this issue Nov 30, 2024 · 1 comment
Open
3 tasks done

Electron tries to run Redhat-specific tools when not using Redhat #3772

DrHyde opened this issue Nov 30, 2024 · 1 comment

Comments

@DrHyde
Copy link

DrHyde commented Nov 30, 2024

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.6.0

Electron version

v33.2.1

Operating system

Devuan GNU/Linux 5 (daedalus), x64

Last known working Electron Forge version

No response

Expected behavior

I tried to build my code on Devuan. The exact same code builds just fine on a Mac. npm run make should produce a working binary in the out/ directory.

Actual behavior

$ npm run make

> [email protected] make
> electron-forge make

✔ Checking your system
✔ Loading configuration
✖ Resolving make targets
  › Cannot make for rpm, the following external binaries need to be installed: rpmbuild
◼ Running package command
◼ Running preMake hook
◼ Making distributables
◼ Running postMake hook

An unhandled rejection has occurred inside Forge:
Error: Cannot make for rpm, the following external binaries need to be installed: rpmbuild
at MakerRpm.ensureExternalBinariesExist (/home/david/unicode-search/node_modules/@electron-forge/maker-base/dist/Maker.js:107:19)
    at /home/david/unicode-search/node_modules/@electron-forge/core/dist/api/make.js:119:27
    at async _Task.taskFn (/home/david/unicode-search/node_modules/@electron-forge/tracer/dist/index.js:58:20)
    at async _Task.run (/home/david/unicode-search/node_modules/listr2/dist/index.cjs:2063:11)

Steps to reproduce

To reproduce:

  • clone my repo, on a Devuan machine;
  • make deps (to install Electron etc)
  • make build

Additional information

A very similar error was reported previously in #1262 and "fixed" by improving the error message to make it clear that Electron is trying to erroneously run Redhat-specific tools on a non-Redhat machine. Making the error message more clear is obviously not in fact a fix. A fix would be a code change to make it stop running Redhat stuff on any platform except Redhat, unless specifically asked to do so, just like you would only run Mac-specific tools on a Mac, and Windows-specific tools on Windows.

@DrHyde
Copy link
Author

DrHyde commented Nov 30, 2024

As a work-around, users who aren't on Redhat can apt-get install rpm but this is obviously far from ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant