Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prePublish and postPublish hooks #3777

Open
3 tasks done
tanishqkancharla opened this issue Dec 5, 2024 · 0 comments
Open
3 tasks done

Add prePublish and postPublish hooks #3777

tanishqkancharla opened this issue Dec 5, 2024 · 0 comments

Comments

@tanishqkancharla
Copy link
Contributor

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

Electron Forge doesn't have publish hooks e.g. prePublish and postPublish. I want these hooks so I can do a version check: I want to ensure in CI that the published version has been updated so that auto-updates work properly for users -- if the published app overwrites the previous version, the app won't auto-update.

Proposed solution

Introduce prePublish and postPublish hooks.

Alternatives considered

I can build around it in CI by just running the version verification command before I publish, but it'd be nice to define all the needed configuration in forge.config.ts, especially because the verification needs assets generated during the generateAssets hook.

Additional information

No response

@tanishqkancharla tanishqkancharla changed the title Add prePublish hooks Add prePublish and postPublish hooks Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants