Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information which is possible to cause conflict to doc #43

Open
LongTengDao opened this issue Mar 8, 2021 · 2 comments
Open

Add information which is possible to cause conflict to doc #43

LongTengDao opened this issue Mar 8, 2021 · 2 comments

Comments

@LongTengDao
Copy link

I saw these ipc channels are used by @electron/remote in the source:

REMOTE_BROWSER_WRONG_CONTEXT_ERROR
REMOTE_BROWSER_REQUIRE
REMOTE_BROWSER_GET_BUILTIN
REMOTE_BROWSER_GET_GLOBAL
REMOTE_BROWSER_GET_CURRENT_WINDOW
REMOTE_BROWSER_GET_CURRENT_WEB_CONTENTS
REMOTE_BROWSER_CONSTRUCTOR
REMOTE_BROWSER_FUNCTION_CALL
REMOTE_BROWSER_MEMBER_CONSTRUCTOR
REMOTE_BROWSER_MEMBER_CALL
REMOTE_BROWSER_MEMBER_SET
REMOTE_BROWSER_MEMBER_GET
REMOTE_BROWSER_DEREFERENCE
REMOTE_BROWSER_CONTEXT_RELEASE

I'm not sure if here are other things like these, which is not written in doc, but could cause bugs that hard to happen and harder to debug.

Add things like these to doc is best. Then the userland won't think any ipc string is usable any more.

@linonetwo
Copy link

I think this conflict won't happen...who will use these strings?

@LongTengDao
Copy link
Author

I think this is like the occupancy of global variables in daily programming, which cannot be ignored because of the low probability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants