Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cloud instances in 'Cluster state' panel #3794

Open
ekazachkova opened this issue Nov 29, 2024 · 1 comment
Open

Support cloud instances in 'Cluster state' panel #3794

ekazachkova opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
kind/enhancement New feature or request state/has-doc Issues that have documentation

Comments

@ekazachkova
Copy link
Contributor

ekazachkova commented Nov 29, 2024

Background
Cloud Pipeline does not show cloud instance at Cluster State panel and it would be nice to support it.

Approach

  • API shall support a new properties for cloud regions:

    • clusterInclude - flag that indicates that instances from this cloud region shall be included into Cluster state panel
    • clusterStateRegionProperties - object describes tag filters for instances that shall be shown (optional)
    {
      "tagsFilter": {
         "instanceTagKey": "instanceTagValue", ...
       }
    }
    
  • API shall be able to manipulate both kubernetes nodes and cloud instances:

    • Load all
      API method GET /cluster/node/loadAll shall support an input parameter machineType=<KUBE|CLOUD|ALL>
      • KUBE - load kubernetes nodes only (default)
      • CLOUD - load cloud instances only from those regions where clusterInclude flag enabled.
      • ALL - load both kubernetes nodes and cloud instances
    • Loads node by name
      API method GET /cluster/node/<instance ID>/load shall support cloud instances and new input parameters
      • machineType=<KUBE|CLOUD|ALL> - default: KUBE
      • regionId (optional) - cloud region ID. If not provided all cloud regions with enabled clusterInclude flag will be scanned.
    • Terminate node by name
      API method DELETE /cluster/node/<instance ID> shall also support input parameters machineType (default: KUBE) and regionId (optional) and cloud instances termination.
  • Returned node object shall contain:

    • a new field machineType
    • a label cloud_region_id
  • AWS sdk methods shall be executed with timeout (this value can be configured via cluster.instance.load.timeout.seconds system preference)

  • All actions with machineType=CLOUD shall be available for admin users only

@ekazachkova ekazachkova added the kind/enhancement New feature or request label Nov 29, 2024
@ekazachkova ekazachkova self-assigned this Nov 29, 2024
sidoruka pushed a commit that referenced this issue Dec 18, 2024
…3798)

* [API] Support cloud instances in 'Cluster state' panel

* [API] Support cloud instances in 'Cluster state' panel - fix for non-admins
ekazachkova added a commit that referenced this issue Dec 20, 2024
… nodes filter (#3837)

* Issue #3794: Support cloud instances in 'Cluster state' panel - cloud nodes filter

* Issue #3794: Support cloud instances in 'Cluster state' panel - cloud nodes filter
rodichenko pushed a commit that referenced this issue Dec 23, 2024
* GUI Issue (#3794): Add Cloud nodes tab

* GUI Issue (#3794): nodes table styling (highlight cloud nodes)

* GUI Issue (#3794): Cloud nodes tab - apply ALL flag to filter

* GUI Issue (#3794): Cloud nodes tab - highlightCloudNodes styling

* GUI Issue (#3794): Cloud nodes tab - highlightCloudNodes styling
ekazachkova added a commit that referenced this issue Dec 26, 2024
ekazachkova added a commit that referenced this issue Dec 26, 2024
* Issue #3794: Support cloud instances in 'Cluster state' panel - cloud nodes filter

(cherry picked from commit d453c0b)

* Issue #3794: Support cloud instances in 'Cluster state' panel - db migration fix

(cherry picked from commit 0ae8b07)

* Issue #3794: Support cloud instances in 'Cluster state' panel - cloud nodes filter

(cherry picked from commit dfd89be)
NShaforostov added a commit that referenced this issue Dec 27, 2024
* (Issue #2444) 'UDP traffic for NAT Gateway' section was added to docs

* (Issue #3794) 'Cloud Nodes' doc was added
@NShaforostov
Copy link
Collaborator

Docs added via #3387 and located here.

@NShaforostov NShaforostov added the state/has-doc Issues that have documentation label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request state/has-doc Issues that have documentation
Projects
None yet
Development

No branches or pull requests

2 participants