Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for guess_type with inchikey in CompoundIdentifier class #1357

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

Ajoke23
Copy link
Contributor

@Ajoke23 Ajoke23 commented Oct 27, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Create a test case to test for a valid inckikey.

Changes to be made

To add a guess type method in the CompoundIdentifier class to correctly identify valid inChikey.

Status

  • Define a test function named test_guess_type_with_inchikey
  • Set a valid inchikey
  • Called a guess_type method
  • Assert the result

To do

Test the code locally

Related to #1319

@DhanshreeA DhanshreeA merged commit edb1aae into ersilia-os:master Nov 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants