Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the readiness check fail for learner #19001

Open
gojoy opened this issue Dec 4, 2024 · 4 comments · May be fixed by #19086
Open

Make the readiness check fail for learner #19001

gojoy opened this issue Dec 4, 2024 · 4 comments · May be fixed by #19086

Comments

@gojoy
Copy link

gojoy commented Dec 4, 2024

What would you like to be added?

RPC read and write operations are not supported for learners, so the readyz check should fail for the learner.

Why is this needed?

When the etcd cluster is running in Kubernetes, the learner's readiness probe should fail. #16007

@siyuanfoundation
Copy link
Contributor

siyuanfoundation commented Dec 11, 2024

Thanks @gojoy for raising the issue. Would you be able to write a PR for this? It is pretty straightforward to add a check in

func installReadyzEndpoints(lg *zap.Logger, mux *http.ServeMux, server ServerHealth) {

based on the server method
func (s *EtcdServer) IsLearner() bool {

and then backport to 3.5, 3.4

@gojoy
Copy link
Author

gojoy commented Dec 12, 2024

ok, please assign this to me @siyuanfoundation

@Dhairya-Dudhatra
Copy link

Can admin please assign this issue to me @siyuanfoundation

@siyuanfoundation
Copy link
Contributor

/assign @gojoy

@gojoy gojoy linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants