Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests should assert output to stderr on errors #170

Open
dwreeves opened this issue Apr 5, 2024 · 0 comments
Open

Unit tests should assert output to stderr on errors #170

dwreeves opened this issue Apr 5, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing Related to testing, coverage, linting, etc.
Milestone
1.9

Comments

@dwreeves
Copy link
Collaborator

dwreeves commented Apr 5, 2024

This is already included in #161, but it is not being formally unit-tested. The current unit-tests do not distinguish between stderr and stdout.

This relates to #164.

This may be related to #163. It's unclear how syrupy works. If it's anything like insta then moving to syrupy makes life easier, but I imagine it's a little more complicated than that.
@dwreeves dwreeves added help wanted Extra attention is needed good first issue Good for newcomers testing Related to testing, coverage, linting, etc. labels Apr 5, 2024
@dwreeves dwreeves added this to the 1.9 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing Related to testing, coverage, linting, etc.
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
1 participant
@dwreeves