You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks really good, and all works great. I find tailwind difficult to read, so no specific CSS feedback 👍 and good job using libraries to help with the heavy lifting so you can focus on functionality. I'm going to be a bit pedantic and say your lists should all use <ul> and <li> - for example your filter buttons and DisplayPlaceCards, amenityList badges etc. as a general rule, if you (could) have two or more similar things, they're an unordered list.
An alternative to the unordered list of buttons, specifically for the filters, would be a fields of radio inputs (!) since they are working in the exact same way. this can help to simplify the handling of clicking, by instead just monitoring the value of the group. it then could also make it easier to combine filters, by converting them into checkboxes which can handle that natively, rather than introducing (slightly more) complicated logic to style and control buttons
The text was updated successfully, but these errors were encountered:
It looks really good, and all works great. I find tailwind difficult to read, so no specific CSS feedback 👍 and good job using libraries to help with the heavy lifting so you can focus on functionality. I'm going to be a bit pedantic and say your lists should all use
<ul>
and<li>
- for example your filter buttons and DisplayPlaceCards, amenityList badges etc. as a general rule, if you (could) have two or more similar things, they're an unordered list.An alternative to the unordered list of buttons, specifically for the filters, would be a fields of radio inputs (!) since they are working in the exact same way. this can help to simplify the handling of clicking, by instead just monitoring the value of the group. it then could also make it easier to combine filters, by converting them into checkboxes which can handle that natively, rather than introducing (slightly more) complicated logic to style and control buttons
The text was updated successfully, but these errors were encountered: