Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: UI #152

Open
jackherizsmith opened this issue Nov 15, 2023 · 0 comments
Open

Feedback: UI #152

jackherizsmith opened this issue Nov 15, 2023 · 0 comments

Comments

@jackherizsmith
Copy link
Contributor

It looks really good, and all works great. I find tailwind difficult to read, so no specific CSS feedback 👍 and good job using libraries to help with the heavy lifting so you can focus on functionality. I'm going to be a bit pedantic and say your lists should all use <ul> and <li> - for example your filter buttons and DisplayPlaceCards, amenityList badges etc. as a general rule, if you (could) have two or more similar things, they're an unordered list.

An alternative to the unordered list of buttons, specifically for the filters, would be a fields of radio inputs (!) since they are working in the exact same way. this can help to simplify the handling of clicking, by instead just monitoring the value of the group. it then could also make it easier to combine filters, by converting them into checkboxes which can handle that natively, rather than introducing (slightly more) complicated logic to style and control buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant