Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update define relationships attributes docs: Optional[Team] -> Team | None #1070

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scku208
Copy link

@scku208 scku208 commented Aug 13, 2024

For users new to SQLModel, the documentation might be confusing. It is recommended to focus on explanations for Python 3.10+ or to include additional parenthetical notes explaining differences from earlier versions.

@github-actions github-actions bot added the docs Improvements or additions to documentation label Aug 13, 2024
Copy link

@scku208
Copy link
Author

scku208 commented Aug 13, 2024

I apologize, but the final reference to Optional[Team] in that particular paragraph should also be updated to Team | None. (also, Optional[int] should be updated to int | None)

@alejsdev alejsdev changed the title Update define relationships attributes docs: Optional[Team] -> Team | None 📝 Update define relationships attributes docs: Optional[Team] -> Team | None Aug 22, 2024
Copy link

github-actions bot commented Sep 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants