Expose pydantic's Field(validation_alias=,serialization_alias=...) parameter #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the SQLModel's main file, the "serialization_alias" parameter has been added. This allows to handle serialization separately if necessary. Simultaneously, a check has been added to pop the "serialization_alias" attribute if it's not present in PydanticFieldInfo.
In the main sqlmodel, validation_alias and serialization_alias have been added as optional attributes. These aliases would provide more flexibility in handling and managing data validation and serialization respectively.
ixycoexzckwpmlcu
suggested changes
Jul 1, 2024
Comment on lines
+154
to
+157
| if not hasattr(PydanticFieldInfo, "validation_alias"): | ||
| kwargs.pop("validation_alias") | ||
| if not hasattr(PydanticFieldInfo, "serialization_alias"): | ||
| kwargs.pop("serialization_alias") |
There was a problem hiding this comment.
This doesn't look necessary (PydanticFieldInfo seems to accept kwargs even if it doesn't use them later)
|
Dear all, it would be totally awesome to release this. The issue exists several months and several versions already #725. Please, let's get some traction here :) |
|
second the push to get this merged as soon as possible please 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands upon and closes PR #774 by adding serialization_alias and missing Field override parameters.
Allows for serializing json using serialization_alias when by_alias is true
object.model_dump_json(by_alias=True)