Should not require socket path to be set in both firecracker.Config and firecracker.VMCommandBuilder #88
Comments
samuelkarp
added a commit
to samuelkarp/firecracker-containerd
that referenced
this issue
Mar 19, 2019
The Firecracker API socket is important for the runtime, as it uses the socket to communicate with Firecracker. Allowing the runtime to fully control the API socket (including its path) removes a potential failure condition from misconfiguration. The API socket is hard-coded to exist within the current working directory. Part of the contract that containerd exposes for runtimes is that they are started with the current working directory changed to be that of the OCI bundle. Using an API socket in the OCI bundle makes its location well-known and predictable to the runtime. Related: firecracker-microvm#59 Related: firecracker-microvm/firecracker-go-sdk#88 Signed-off-by: Samuel Karp <[email protected]>
samuelkarp
added a commit
to samuelkarp/firecracker-containerd
that referenced
this issue
Mar 19, 2019
The Firecracker API socket is important for the runtime, as it uses the socket to communicate with Firecracker. Allowing the runtime to fully control the API socket (including its path) removes a potential failure condition from misconfiguration. The API socket is hard-coded to exist within the current working directory. Part of the contract that containerd exposes for runtimes is that they are started with the current working directory changed to be that of the OCI bundle. Using an API socket in the OCI bundle makes its location well-known and predictable to the runtime. Related: firecracker-microvm#59 Related: firecracker-microvm/firecracker-go-sdk#88 Signed-off-by: Samuel Karp <[email protected]>
|
If a customer is using Line 319 in 6237a44 I think that covers most of use cases. Do we want to improve UX even further for customers who use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The SDK currently requires the socket path to be set in two places, and for it to be set to the same thing:
firecracker.VMCommandBuilderis used for building the command to start thefirecrackerbinary. Specifying the socket path here adds the--api-sockcommand-line argument that tells Firecracker to open the socket in a particular location.firecracker.Configis used in the API client so that the client knows how to talk to the Firecracker API.In order to both start a VM and communicate with it, a user of this SDK is required to specify the socket path in both places. If the user is intending to start a VM and immediately control it (which I think is the most common case), we should make it simpler to do so and allow the field to be specified only once.
The text was updated successfully, but these errors were encountered: