Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : added a new profile page to help teachers create their profile. #254

Closed
wants to merge 3 commits into from

Conversation

PrajwalPisal
Copy link

Checklist:

Closes #2

Description:

This pull request adds a new feature to the project: a teacher profile page where teachers can create and edit their profile information. The page is built using Next.js and uses the localStorage API to store user data as a JSON object, ensuring that the user's data will persist even after the user closes the browser or navigates away from the page.

On the profile page, teachers can input their name, email, university, and a short bio. The page is designed to be user-friendly and easy to navigate. The information is not yet stored in a database, but the use of localStorage provides a temporary solution until further development is done.

@PrajwalPisal PrajwalPisal requested a review from a team as a code owner February 23, 2023 00:31
@roberthuskins
Copy link
Contributor

roberthuskins commented Feb 27, 2023

@PrajwalPisal can you add some pictures to the PR for future reference?
Also if you want to merge this pull request I would recommend not linking this page anywhere else in the app since as you mentioned saving the user's profile to localstorage is temporary. When saving to DB is done we can link it.

You can add some fields to the Prisma Schema no problem to help you with the DB, just make a separate PR for us.

<div className='flex text-lg text-white justify-center items-center'>
<div className='profile'>
<div className='profile-pic'>
<img
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use next/image as pointed out by codefactor

@GuillermoFloresV
Copy link
Member

Closed due to inactivity.

If you would still like to contribute, please resubmit this PR with the appropriate changes mentioned by Robert.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding for a Teacher
3 participants