Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up functions for both store and site #8

Open
6 of 8 tasks
drewbaker opened this issue Sep 13, 2015 · 2 comments
Open
6 of 8 tasks

Clean up functions for both store and site #8

drewbaker opened this issue Sep 13, 2015 · 2 comments
Assignees

Comments

@drewbaker
Copy link
Member

drewbaker commented Sep 13, 2015

Here are some things I need to clean up:

  • Remove inline arrays from second image function (use $args).
  • Remove use of global in meta box functions
  • Correct save key for second image
  • Add get_second_post_thumbnail() function to boilerplate from Kinfolk
  • Update production variation function to respect attribute names (as done on Kinfolk). Build in some caching perhaps?
  • Update template to use price_html function as per Kinfolk or write something better that accounts for display price (price + tax), sale, free, discount, currency type etc.
  • Include get_product_brand function in boiler plate? Build in some caching? Maybe better to put all these onto Stackoverflow?
  • Probably worth making store filters get applied in a certain order always, probably top down, so it goes clothing+shirts+kinfolk instead of clothing+kinfolk+shirts? Maybe? Maybe better to apply them in the order they are clicked, as currently done.
@drewbaker drewbaker self-assigned this Sep 13, 2015
@SaFrMo
Copy link
Contributor

SaFrMo commented Jan 23, 2017

@drewbaker Updating this list to be as current as possible

@drewbaker
Copy link
Member Author

We can remove all store stuff, I don't think we are going to use WooCommerce ever again now that we have Shopify plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants