Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e integration with stacks such as Rails #468

Open
2 of 7 tasks
BYK opened this issue Jul 31, 2024 · 4 comments
Open
2 of 7 tasks

Improve e2e integration with stacks such as Rails #468

BYK opened this issue Jul 31, 2024 · 4 comments
Assignees
Labels
Type: Enhancement New feature or request

Comments

@BYK
Copy link
Member

BYK commented Jul 31, 2024

I recently tried to integrate Spotlight with a basic Rails app and it was a very cumbersome experience.

  • It's not clear that we need the Ruby SDK to get the full value out of Spotlight
  • It's not clear that having JS SDK on the frontend provides much more value.
  • - We should probably add call to actions both on docs and under certain tabs on the UI
  • - We should provide a "Add Sentry JS SDK" snippet there too, or provide a Spotlight bundle that already does this
  • It's not clear how/which version of Spotlight to use: Pure HTML, or Electron, or npx @spotlightjs/spotlight + Web Browser. We should pick one golden path and promote it
  • Pure HTML integration of Spotlight is very confusing as it requires 3 separate script tags (feat: Add IIFE bundle for single script include #478)
  • Spotlight relies too much on running in the same page with the front-end application, such as automatically enabling Sentry JS SDK for itself. Sentry JS SDK should do these automatically when spotlight: true is passed and Spotlight should not rely on being on the same global execution environment with the Sentry JS SDK for best integration (feat: Add spotlightBrowser integration sentry-javascript#13263)
@BYK BYK self-assigned this Jul 31, 2024
@BYK
Copy link
Member Author

BYK commented Aug 1, 2024

Related: #403

@BYK
Copy link
Member Author

BYK commented Aug 7, 2024

Pure HTML part was handled by #478.

@BYK
Copy link
Member Author

BYK commented Aug 7, 2024

Spotlight relying on running in the same page with Sentry Browser SDK is being addressed in getsentry/sentry-javascript#13263

@BYK
Copy link
Member Author

BYK commented Oct 31, 2024

Related #543.

@smeubank smeubank added the Type: Enhancement New feature or request label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants