Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing additional extensions for systemd INI format style files #7161

Open
vorburger opened this issue Dec 14, 2024 · 2 comments · May be fixed by #7163
Open

Missing additional extensions for systemd INI format style files #7161

vorburger opened this issue Dec 14, 2024 · 2 comments · May be fixed by #7163
Labels
Bug

Comments

@vorburger
Copy link
Contributor

Describe the bug

I noticed on my vorburger/vorburger-dotfiles-bin-etc@d6eb521 that a (systemd, INI format style) .service had syntax highlighting, but .timer did not:

$ github-linguist systemd/flatpak-update.service
systemd/flatpak-update.service: 6 lines (5 sloc)
  type:      Text
  mime type: text/plain
  language:  desktop

$ github-linguist systemd/flatpak-update.timer
systemd/flatpak-update.timer: 10 lines (8 sloc)
  type:      Text
  mime type: text/plain
  language:

I'll see if it's easy enough to contribute a PR with a proposed fix for this...
@vorburger vorburger added the Bug label Dec 14, 2024
@vorburger
Copy link
Contributor Author

vorburger commented Dec 14, 2024 •
edited
Loading

I've found that #5767 for #5750 originally added systemd detection support. But since then this is longer like that; the systemd "language" (for .service, .sys and .dll and .inf) appears to have been removed again at some point.

In #5768 for #5750 the systemd .service detection appears to have been re-added by @Alhadis, and this is currently part of the desktop "language" (together with .desktop and .desktop.in). Ergo I'll propose adding this there.

While I am at it, I'll propose adding a number of other systemd configuration file name extensions which use the same syntax (which is really just an INI file).

vorburger added a commit to vorburger/linguist that referenced this issue Dec 14, 2024
@vorburger
Add .timer & various other systemd extensions (fixes github-linguis…
05f0cd6 
…t#7161)
@vorburger vorburger linked a pull request Dec 14, 2024 that will close this issue
Open
4 tasks
@vorburger
Copy link
Contributor Author

While I am at it, I'll propose adding a number of other systemd configuration file name extensions which use the same syntax

Actually, this works for non-common extensions, but is more debatable for the more common ones...

... after carefully evaluating this more, I have decided NOT to include these extensions:

The remaining ones are proposed in #7163.

vorburger added a commit to vorburger/linguist that referenced this issue Dec 14, 2024
@vorburger
Remove a number of extensions used by systemd INI files which are too…
1a61b82 
… common (see github-linguist#7161)
@vorburger vorburger mentioned this issue Dec 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add .timer & various other systemd extensions (fixes #7161) vorburger/linguist
1 participant
@vorburger