feat: add --force-yaml-string-quotation forcing string quotation for rendered YAML #731
Conversation
Signed-off-by: Matthias Riegler <[email protected]>
fixes grafana#687 Signed-off-by: Matthias Riegler <[email protected]>
Signed-off-by: Matthias Riegler <[email protected]>
xvzf
force-pushed
the
fix/issue-687-flux-substitution
branch
from
d02b8ea to
a1a9ecf
Compare
| @@ -9,9 +9,19 @@ import ( | |||
| "github.com/Masterminds/sprig/v3" | |||
| "github.com/pkg/errors" | |||
| "github.com/stretchr/objx" | |||
| yaml "gopkg.in/yaml.v2" | |||
| yaml "gopkg.in/yaml.v3" | |||
There was a problem hiding this comment.
That's going to be a blocker for us 😞. v3 has major formatting differences from v2, and there's no way to configure it (see #607 (comment)). For anyone using GitOps, this upgrade is very troublesome because it means that most Kubernetes resources will be redeployed
There was a problem hiding this comment.
Damn, didn't think about this, thought this had been resolved already. Do you consider switching to the fork the kustomize folks are using right now? With the v2 API, we cannot have such functionalities
There was a problem hiding this comment.
If we can maintain the same indentations as we currently have, and it supports new features such as this, then I think it'd be a good option
There was a problem hiding this comment.
So - the short version of this is that we cannot, I'll check if I can come up with another way, maybe a feature flag like --use-yaml-v3?
This PR adds the
--force-yaml-string-quotationwhich patches theyaml.Nodeobject and adds a custom formatting option to inject quotes around strings.Fixes #687