Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Button Kind explanation #340

Open
jcfilben opened this issue Dec 14, 2021 · 1 comment
Open

Improve Button Kind explanation #340

jcfilben opened this issue Dec 14, 2021 · 1 comment

Comments

@jcfilben
Copy link
Collaborator

There is some confusion about Button kind. The docs should be improved to potentially include a button kind example, clarify that kind is not a prop, include the grommet version button kind was added in instead of the month and year it was added.

See more details about this issue in this slack thread: https://grommet.slack.com/archives/C09QQEG69/p1639148987111700

@jcfilben
Copy link
Collaborator Author

Additional note: the explanation for button kind incorrectly implies that primary and secondary can't be used if button.default is not defined in the theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant