Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azure machine learning module #1372

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add azure machine learning module #1372

wants to merge 11 commits into from

Conversation

hattan
Copy link
Contributor

@hattan hattan commented Nov 7, 2023

Description

Added support for Azure Machine Learning Workspace and Azure Machine Learning Workspace Compute.
Fixes #1371.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes

Added support for Azure Machine Learning Workspace and Azure Machine Learning Workspace Compute.

@hattan hattan requested a review from denis256 as a code owner November 7, 2023 19:31
@HadwaAbdelhalem
Copy link
Contributor

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/HadwaAbdelhalem/terratest/actions/runs/6791271804

@hattan
Copy link
Contributor Author

hattan commented Nov 8, 2023

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/HadwaAbdelhalem/terratest/actions/runs/6791271804

The failing tests are expected and due to quota limits on the Azure account used for testing. However, the new module introduced here (Azure Machine Learning) is passing.

@HadwaAbdelhalem
Copy link
Contributor

HadwaAbdelhalem commented Nov 8, 2023 •
edited
Loading

LGTM! confirmed the failed tests are due to quota restrictions on the azure test subscription. @denis256 can you please review it.

@hattan hattan changed the title Add azure compute module Add azure machine learning module Nov 8, 2023
@denis256
Copy link
Member

@HadwaAbdelhalem
Hi,
looks like imports should be fixed:

goimports................................................................Failed
- hook id: goimports
- files were modified by this hook

modules/azure/machinelearning.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Azure] Support for Azure Machine Learning
3 participants
@hattan @HadwaAbdelhalem @denis256