Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing build step on "next steps" #69

Open
Giuliano1993 opened this issue Jan 6, 2024 · 1 comment
Open

Missing build step on "next steps" #69

Giuliano1993 opened this issue Jan 6, 2024 · 1 comment

Comments

@Giuliano1993
Copy link

When starting a project, in the list of suggest next steps we've got:

  1. Click the Load unpacked extension button.
  2. Select the build/ directory that was created.

putting a step in the middle telling to run npm run build would make things clearer for devs who are less into JS processes!
I can open a PR for this If you want

@mrienstra
Copy link

docs(i18n):Deutsch changes to index.ts added some redundancy to the instructions, and maybe a bit too much indentation as well.

Sample, when using pnpm:

Done. Now run:

  cd my-crx-app
  pnpm install
  pnpm run dev

   Suggest you next step:
    1. cd my-crx-app
    2. Run pnpm install
    3. Open chrome://extensions/ in your browser
    4. Check the box for Developer mode in the top right.
    5. Click the Load unpacked extension button.
    6. Select the build/ directory that was created.

Could change to something more like:

Done. Now run:

cd my-crx-app
pnpm install
pnpm run dev

To load the extension:

  1. Open chrome://extensions in your browser.
  2. Enable Developer Mode by clicking the toggle switch next to Developer mode (top right).
  3. Click the Load unpacked button and select the build/ directory.

See index.ts#L375-L397 for current source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants