Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the browser tests by extending the browserDisconnectTimeout #1468

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix the browser tests by extending the browserDisconnectTimeout #1468

merged 1 commit into from
Dec 4, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Dec 4, 2024 •
edited
Loading

Context

In karma configuration I extended browserDisconnectTimeout to 60s. It fixed the problem.

How did you test your changes?

  • browser tests run with no issues locally
  • browser tests run with no issues in GH actions env

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation
  • Improve the dev tooling

Related issues:

  1. Fixes Fix the browser tests Disconnected (0 times) reconnect failed before timeout of 2000ms (ping timeout) error #1430

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Dec 4, 2024
@sequba sequba linked an issue Dec 4, 2024 that may be closed by this pull request
Fix the browser tests Disconnected (0 times) reconnect failed before timeout of 2000ms (ping timeout) error #1430
Open
@sequba sequba requested a review from budnix December 4, 2024 13:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Performance comparison of head (110ae1d) vs base (fa06221)

                                     testName |   base |   head |  change
-------------------------------------------------------------------------
                                      Sheet A | 502.94 |  512.3 |  +1.86%
                                      Sheet B | 165.96 | 169.66 |  +2.23%
                                      Sheet T | 143.11 | 149.01 |  +4.12%
                                Column ranges | 508.93 | 523.93 |  +2.95%
Sheet A:  change value, add/remove row/column |  14.52 |  17.53 | +20.73%
 Sheet B: change value, add/remove row/column | 121.94 | 143.94 | +18.04%
                   Column ranges - add column | 152.08 | 173.24 | +13.91%
                Column ranges - without batch | 433.59 | 491.16 | +13.28%
                        Column ranges - batch | 112.78 | 125.34 | +11.14%

@sequba sequba merged commit bf325c3 into develop Dec 4, 2024
24 checks passed
@sequba sequba deleted the feature/issue-1430 branch December 4, 2024 14:29
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (fa06221) to head (110ae1d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1468   +/-   ##
========================================
  Coverage    97.20%   97.20%           
========================================
  Files          169      169           
  Lines        14430    14430           
  Branches      3027     3027           
========================================
  Hits         14027    14027           
  Misses         403      403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnix budnix budnix approved these changes

Assignees

@sequba sequba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the browser tests Disconnected (0 times) reconnect failed before timeout of 2000ms (ping timeout) error
2 participants
@sequba @budnix