Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Realtime Connections Support #17

Open
frankli0324 opened this issue Jun 10, 2020 · 4 comments
Open

Add Realtime Connections Support #17

frankli0324 opened this issue Jun 10, 2020 · 4 comments
Assignees
@SamJakob
Labels
in progress this feature is being developed

Comments

@frankli0324
Copy link

related: hoppscotch/hoppscotch#175
@frankli0324 frankli0324 changed the title Add Websocket Support Add Realtime Connections Support Jun 10, 2020
@NBTX
Copy link
Contributor

NBTX commented Jun 10, 2020

So there is definitely a plan to implement WebSockets support into the Go proxy on the roadmap, my main concern however is usage of server resources especially on our official server. I may just add an optional flag or setting that can be supplied to the server to toggle the capability.

Just referring to the other issue, could you clarify what you meant by "still trying to adopt the original version of http proxy server so we could use a single proxy for both types of requests"?

@NBTX NBTX self-assigned this Jun 10, 2020
@frankli0324
Copy link
Author

sorry for the late response
back then I was not familiar with proxywoman and it's implementation of the proxy, so I said something stupid(

@NBTX
Copy link
Contributor

NBTX commented Jun 12, 2020

Ah, no worries!

@NBTX NBTX pinned this issue Jun 12, 2020
@NBTX NBTX added the in progress this feature is being developed label Mar 9, 2021
@NBTX NBTX assigned SamJakob and unassigned NBTX Oct 12, 2021
@SamJakob
Copy link
Contributor

SamJakob commented Sep 3, 2023

See also hoppscotch/hoppscotch:#3062.

Especially with the push for Hoppscotch as an enterprise product and for self-hosting purposes I think it would be useful to add this functionality to the proxy even if it is not used by hoppscotch officially due to the aforementioned concerns about resource consumption.

I will look to implement this in the proxy server behind a --enable-websockets flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamJakob SamJakob

Labels
in progress this feature is being developed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@frankli0324 @SamJakob @NBTX and others